Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2722983004: Use ApplyAnimations enum parameter instead of bool for callsite readability (Closed)

Created:
3 years, 9 months ago by alancutter (OOO until 2018)
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ApplyAnimations enum parameter instead of bool for callsite readability This patch changes the bool in applyCustomProperty() to an ApplyAnimations enum to make it easier to read at the callsites what is being done. The ApplyAnimations enum and its values matches the convention used in ComputedStyle by ApplyTransformOrigin, ApplyMotionPath and ApplyIndependentTransformProperties. Review-Url: https://codereview.chromium.org/2722983004 Cr-Commit-Position: refs/heads/master@{#454498} Committed: https://chromium.googlesource.com/chromium/src/+/bbb3bb2234561db8ddf52e905770e4109c56ae28

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
alancutter (OOO until 2018)
3 years, 9 months ago (2017-03-02 05:46:07 UTC) #2
meade_UTC10
lgtm
3 years, 9 months ago (2017-03-02 05:46:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722983004/20001
3 years, 9 months ago (2017-03-03 03:05:58 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 03:22:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bbb3bb2234561db8ddf52e905770...

Powered by Google App Engine
This is Rietveld 408576698