Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2724153002:
ScriptStreamer: make state variables main-thread-only. (Closed)
DescriptionScriptStreamer: make state variables main-thread-only.
After this CL, |m_parsingFinished| is not set to true until the task posted
back to the main thread runs. After that, all access to the boolean variables
commented as protected by |ScriptStreamer::m_mutex| seems to be on the main
thread, so the mutex is also removed.
BUG=697651
Review-Url: https://codereview.chromium.org/2724153002
Cr-Commit-Position: refs/heads/master@{#454568}
Committed: https://chromium.googlesource.com/chromium/src/+/84609d29dbdaffc45415fc4b7ef6443096473d8b
Patch Set 1 #Patch Set 2 : also update comment #
Total comments: 2
Patch Set 3 : remove reference to mutex in comment #
Messages
Total messages: 29 (21 generated)
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ScriptStreamer: make state variables main-thread-only. BUG= ========== to ========== ScriptStreamer: make state variables main-thread-only. BUG=697651 ==========
Description was changed from ========== ScriptStreamer: make state variables main-thread-only. BUG=697651 ========== to ========== ScriptStreamer: make state variables main-thread-only. After this CL, |m_parsingFinished| is not set to true until the task posted back to the main thread runs. After that, all access to the boolean variables commented as protected by |ScriptStreamer::m_mutex| seems to be on the main thread, so the mutex is also removed. BUG=697651 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
jbroman@chromium.org changed reviewers: + marja@chromium.org
LGTM
sigbjornf@opera.com changed reviewers: + sigbjornf@opera.com
https://codereview.chromium.org/2724153002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp (right): https://codereview.chromium.org/2724153002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp:375: // The task might delete ScriptStreamer, so it's not safe to do anything Update this comment a bit?
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
jbroman@chromium.org changed reviewers: + haraken@chromium.org
https://codereview.chromium.org/2724153002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp (right): https://codereview.chromium.org/2724153002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp:375: // The task might delete ScriptStreamer, so it's not safe to do anything On 2017/03/02 at 18:34:27, sof wrote: > Update this comment a bit? Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by jbroman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2724153002/#ps40001 (title: "remove reference to mutex in comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488545319388110,
"parent_rev": "303f444d68f7f76722c98987afbdc6bcb466fd67", "commit_rev":
"84609d29dbdaffc45415fc4b7ef6443096473d8b"}
Message was sent while issue was closed.
Description was changed from ========== ScriptStreamer: make state variables main-thread-only. After this CL, |m_parsingFinished| is not set to true until the task posted back to the main thread runs. After that, all access to the boolean variables commented as protected by |ScriptStreamer::m_mutex| seems to be on the main thread, so the mutex is also removed. BUG=697651 ========== to ========== ScriptStreamer: make state variables main-thread-only. After this CL, |m_parsingFinished| is not set to true until the task posted back to the main thread runs. After that, all access to the boolean variables commented as protected by |ScriptStreamer::m_mutex| seems to be on the main thread, so the mutex is also removed. BUG=697651 Review-Url: https://codereview.chromium.org/2724153002 Cr-Commit-Position: refs/heads/master@{#454568} Committed: https://chromium.googlesource.com/chromium/src/+/84609d29dbdaffc45415fc4b7ef6... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/84609d29dbdaffc45415fc4b7ef6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
