Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h

Issue 2724153002: ScriptStreamer: make state variables main-thread-only. (Closed)
Patch Set: remove reference to mutex in comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
index d9e6638fd6757421ac3644408ff4aeffe5bf1bef..f6885200ff40bbbcc161ed1f5370adb5098a2e8b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
@@ -141,14 +141,12 @@ class CORE_EXPORT ScriptStreamer final
SourceStream* m_stream;
std::unique_ptr<v8::ScriptCompiler::StreamedSource> m_source;
bool m_loadingFinished; // Whether loading from the network is done.
- // Whether the V8 side processing is done. Will be used by the main thread
- // and the streamer thread; guarded by m_mutex.
- bool m_parsingFinished;
+ bool m_parsingFinished; // Whether the V8 side processing is done.
// Whether we have received enough data to start the streaming.
bool m_haveEnoughDataForStreaming;
// Whether the script source code should be retrieved from the Resource
- // instead of the ScriptStreamer; guarded by m_mutex.
+ // instead of the ScriptStreamer.
bool m_streamingSuppressed;
// What kind of cached data V8 produces during streaming.
@@ -165,8 +163,6 @@ class CORE_EXPORT ScriptStreamer final
// Keep the script resource dentifier for event tracing.
const unsigned long m_scriptResourceIdentifier;
- mutable Mutex m_mutex;
-
// Encoding of the streamed script. Saved for sanity checking purposes.
v8::ScriptCompiler::StreamedSource::Encoding m_encoding;
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698