Remove renderer-to-renderer input event forwarding for OOPIFs

Remove renderer-to-renderer input event forwarding for OOPIFs

Now that the browser process supports focus tracking and
mouse/touch/gesture event hit testing for OOPIFs on all platforms, we
no longer need to ability to forward events from a parent frame
renderer to a child frame renderer. This patch removes that code.

BUG=650348
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2723963003
Cr-Commit-Position: refs/heads/master@{#460177}
Committed: https://chromium.googlesource.com/chromium/src/+/e2da63fad40fc329932c04030bca51f366ed721c

[kenrb, 2017-03-01 18:30:32]

Description was changed from

==========
Remove renderer-to-renderer input event forwarding for OOPIFs

Now that the browser process supports focus tracking and
mouse/touch/gesture event hit testing for OOPIFs on all platforms, we
no longer need to ability to forward events from a parent frame
renderer to a child frame renderer. This patch removes that code.

BUG=650348
==========

to

==========
Remove renderer-to-renderer input event forwarding for OOPIFs

Now that the browser process supports focus tracking and
mouse/touch/gesture event hit testing for OOPIFs on all platforms, we
no longer need to ability to forward events from a parent frame
renderer to a child frame renderer. This patch removes that code.

BUG=650348
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[kenrb, 2017-03-01 18:30:37]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 18:31:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 19:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 19:56:33]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[kenrb, 2017-03-03 15:25:10]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 15:25:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 17:03:54]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[kenrb, 2017-03-09 16:06:17]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:06:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 17:51:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:51:42]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[kenrb, 2017-03-24 19:26:15]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 19:26:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:36:34]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[kenrb, 2017-03-27 19:15:33]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:16:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-03-27 20:37:41]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 20:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-03-27 20:41:39]

kenrb@chromium.org changed reviewers:
+ dcheng@chromium.org

[kenrb, 2017-03-27 20:41:40]

dcheng: PTAL?

As I mentioned offline, this causes one layout test to fail, but I'd like to fix
that in a follow-up CL on the same bug. It is clearly a test issue, since the
main frame uses EventSender to click on an OOPIF.

Other than the modified test expectation, this is only code deletion. There is a
chance this could break things, but if so then we need to learn about that
breakage anyway.

[dcheng, 2017-03-27 21:15:25]

This change LGTM, but I'm wondering if we should start with a slightly less
aggressive CL first: say we land this, and we find out that something critical
relies on this.

For example, maybe we could just not send the forwarding IPC message initially?

[dcheng, 2017-03-27 21:15:39]

(That being said, if you're comfortable with this CL, then I'm happy)

[commit-bot: I haz the power, 2017-03-27 22:16:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:16:41]

Dry run: This issue passed the CQ dry run.

[kenrb, 2017-03-28 14:08:48]

kenrb@chromium.org changed reviewers:
+ nick@chromium.org

[kenrb, 2017-03-28 14:08:49]

I think I would rather land as-is, accepting that it might be slightly harder to
revert if there is a problem.

Nick, can you look at this as content/ OWNER?

[ncarter (slow), 2017-03-28 18:21:15]

lgtm

[kenrb, 2017-03-28 18:36:53]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2017-03-28 18:37:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:44:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490726213273150,
"parent_rev": "34662d716488c15221573880f3462b1a3e2c123c", "commit_rev":
"e2da63fad40fc329932c04030bca51f366ed721c"}

[commit-bot: I haz the power, 2017-03-28 18:45:48]

Description was changed from

==========
Remove renderer-to-renderer input event forwarding for OOPIFs

Now that the browser process supports focus tracking and
mouse/touch/gesture event hit testing for OOPIFs on all platforms, we
no longer need to ability to forward events from a parent frame
renderer to a child frame renderer. This patch removes that code.

BUG=650348
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove renderer-to-renderer input event forwarding for OOPIFs

Now that the browser process supports focus tracking and
mouse/touch/gesture event hit testing for OOPIFs on all platforms, we
no longer need to ability to forward events from a parent frame
renderer to a child frame renderer. This patch removes that code.

BUG=650348
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2723963003
Cr-Commit-Position: refs/heads/master@{#460177}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2da63fad40fc329932c04030bca...
==========

[commit-bot: I haz the power, 2017-03-28 18:45:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e2da63fad40fc329932c04030bca...

[alexmos, 2017-03-31 06:30:11]

alexmos@chromium.org changed reviewers:
+ alexmos@chromium.org

[alexmos, 2017-03-31 06:30:12]

https://codereview.chromium.org/2723963003/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/FlagExpectations/site-per-process (right):

https://codereview.chromium.org/2723963003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/FlagExpectations/site-per-process:176:
crbug.com/650348 http/tests/webaudio/autoplay-crossorigin.html [ Timeout ]
This is causing a failure on
virtual/mojo-loading/http/tests/webaudio/autoplay-crossorigin.html on Site
Isolation Win:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/bui...

Ken, could you please add that one to these expectations as well?