Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 2723963003: Remove renderer-to-renderer input event forwarding for OOPIFs (Closed)
Patch Set: Correct test expectation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/cross_process_frame_connector.cc
diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc
index b56680ddfbc2a0466ab21b1467d4c4e2b4b5abca..03d3271ee4bbfee784ab96b1cc4e2d3f33fe151a 100644
--- a/content/browser/frame_host/cross_process_frame_connector.cc
+++ b/content/browser/frame_host/cross_process_frame_connector.cc
@@ -40,7 +40,6 @@ bool CrossProcessFrameConnector::OnMessageReceived(const IPC::Message& msg) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(CrossProcessFrameConnector, msg)
- IPC_MESSAGE_HANDLER(FrameHostMsg_ForwardInputEvent, OnForwardInputEvent)
IPC_MESSAGE_HANDLER(FrameHostMsg_FrameRectChanged, OnFrameRectChanged)
IPC_MESSAGE_HANDLER(FrameHostMsg_UpdateViewportIntersection,
OnUpdateViewportIntersection)
@@ -237,50 +236,6 @@ void CrossProcessFrameConnector::UnlockMouse() {
root_view->UnlockMouse();
}
-void CrossProcessFrameConnector::OnForwardInputEvent(
- const blink::WebInputEvent* event) {
- if (!view_)
- return;
-
- RenderFrameHostManager* manager =
- frame_proxy_in_parent_renderer_->frame_tree_node()->render_manager();
- RenderWidgetHostImpl* parent_widget =
- manager->ForInnerDelegate()
- ? manager->GetOuterRenderWidgetHostForKeyboardInput()
- : frame_proxy_in_parent_renderer_->GetRenderViewHost()->GetWidget();
-
- // TODO(wjmaclean): We should remove these forwarding functions, since they
- // are directly target using RenderWidgetHostInputEventRouter. But neither
- // pathway is currently handling gesture events, so that needs to be fixed
- // in a subsequent CL.
- if (blink::WebInputEvent::isKeyboardEventType(event->type())) {
- if (!parent_widget->GetLastKeyboardEvent())
- return;
- NativeWebKeyboardEvent keyboard_event(
- *parent_widget->GetLastKeyboardEvent());
- view_->ProcessKeyboardEvent(keyboard_event);
- return;
- }
-
- if (blink::WebInputEvent::isMouseEventType(event->type())) {
- // TODO(wjmaclean): Initialize latency info correctly for OOPIFs.
- // https://crbug.com/613628
- ui::LatencyInfo latency_info;
- view_->ProcessMouseEvent(*static_cast<const blink::WebMouseEvent*>(event),
- latency_info);
- return;
- }
-
- if (event->type() == blink::WebInputEvent::MouseWheel) {
- // TODO(wjmaclean): Initialize latency info correctly for OOPIFs.
- // https://crbug.com/613628
- ui::LatencyInfo latency_info;
- view_->ProcessMouseWheelEvent(
- *static_cast<const blink::WebMouseWheelEvent*>(event), latency_info);
- return;
- }
-}
-
void CrossProcessFrameConnector::OnFrameRectChanged(
const gfx::Rect& frame_rect) {
if (!frame_rect.size().IsEmpty())

Powered by Google App Engine
This is Rietveld 408576698