Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Issue 2723963003: Remove renderer-to-renderer input event forwarding for OOPIFs (Closed)
Patch Set: Correct test expectation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/RemoteFrame.h" 5 #include "core/frame/RemoteFrame.h"
6 6
7 #include "bindings/core/v8/WindowProxy.h" 7 #include "bindings/core/v8/WindowProxy.h"
8 #include "bindings/core/v8/WindowProxyManager.h" 8 #include "bindings/core/v8/WindowProxyManager.h"
9 #include "core/dom/RemoteSecurityContext.h" 9 #include "core/dom/RemoteSecurityContext.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 RemoteSecurityContext* RemoteFrame::securityContext() const { 115 RemoteSecurityContext* RemoteFrame::securityContext() const {
116 return m_securityContext.get(); 116 return m_securityContext.get();
117 } 117 }
118 118
119 bool RemoteFrame::shouldClose() { 119 bool RemoteFrame::shouldClose() {
120 // TODO(nasko): Implement running the beforeunload handler in the actual 120 // TODO(nasko): Implement running the beforeunload handler in the actual
121 // LocalFrame running in a different process and getting back a real result. 121 // LocalFrame running in a different process and getting back a real result.
122 return true; 122 return true;
123 } 123 }
124 124
125 void RemoteFrame::forwardInputEvent(Event* event) {
126 client()->forwardInputEvent(event);
127 }
128
129 void RemoteFrame::setView(RemoteFrameView* view) { 125 void RemoteFrame::setView(RemoteFrameView* view) {
130 // Oilpan: as RemoteFrameView performs no finalization actions, 126 // Oilpan: as RemoteFrameView performs no finalization actions,
131 // no explicit dispose() of it needed here. (cf. FrameView::dispose().) 127 // no explicit dispose() of it needed here. (cf. FrameView::dispose().)
132 m_view = view; 128 m_view = view;
133 } 129 }
134 130
135 void RemoteFrame::createView() { 131 void RemoteFrame::createView() {
136 // If the RemoteFrame does not have a LocalFrame parent, there's no need to 132 // If the RemoteFrame does not have a LocalFrame parent, there's no need to
137 // create a widget for it. 133 // create a widget for it.
138 if (!deprecatedLocalOwner()) 134 if (!deprecatedLocalOwner())
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 FrameVector childrenToDetach; 166 FrameVector childrenToDetach;
171 childrenToDetach.reserveCapacity(tree().childCount()); 167 childrenToDetach.reserveCapacity(tree().childCount());
172 for (Frame* child = tree().firstChild(); child; 168 for (Frame* child = tree().firstChild(); child;
173 child = child->tree().nextSibling()) 169 child = child->tree().nextSibling())
174 childrenToDetach.push_back(child); 170 childrenToDetach.push_back(child);
175 for (const auto& child : childrenToDetach) 171 for (const auto& child : childrenToDetach)
176 child->detach(FrameDetachType::Remove); 172 child->detach(FrameDetachType::Remove);
177 } 173 }
178 174
179 } // namespace blink 175 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698