Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2723493004: Move FrameHost::m_pageScaleConstraintsSet to Page (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FrameHost::m_pageScaleConstraintsSet to Page This is part of merging FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2723493004 Cr-Commit-Position: refs/heads/master@{#454188} Committed: https://chromium.googlesource.com/chromium/src/+/60bfbf8a7d59d1f63b5a73f1ac10dee41c6a7ded

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
sashab
3 years, 9 months ago (2017-02-28 05:08:37 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-28 05:09:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723493004/20001
3 years, 9 months ago (2017-03-02 03:46:08 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 05:53:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60bfbf8a7d59d1f63b5a73f1ac10...

Powered by Google App Engine
This is Rietveld 408576698