Remove |remote| and |readonly| members of MediaStreamTrack.

Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG=598704
Review-Url: https://codereview.chromium.org/2723433002
Cr-Commit-Position: refs/heads/master@{#456639}
Committed: https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672

[Yeol Park, 2017-02-27 07:50:08]

Description was changed from

==========
Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG=598704
==========

to

==========
Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG=598704
==========

[Yeol Park, 2017-02-27 07:50:08]

peary2@gmail.com changed reviewers:
+ aelias@chromium.org, bbudge@chromium.org, dpranke@chromium.org,
drott@chromium.org, emircan@chromium.org, esprehn@chromium.org,
guidou@chromium.org, hongchan@chromium.org, hta@chromium.org,
peter@chromium.org, rdevlin.cronin@chromium.org, sergeyu@chromium.org

[Yeol Park, 2017-02-27 07:53:06]

PTAL :)

rdevlin.cronin@ for chrome/renderer/extensions/*
esprehn@ for content/renderer/media/*
sergeyu@ for content/renderer/media/webrtc/*
emircan@ for content/renderer/media_recorder/*
bbudge@ for content/renderer/pepper/*
dpranke@ for third_party/WebKit/LayoutTests/external/wpt/*
guidou@ for third_party/WebKit/Source/modules/mediastream/*
hongchan@ for third_party/WebKit/Source/modules/webaudio/*
drott@ for third_party/WebKit/Source/platform/*
aelias@ for third_party/WebKit/public/platform/*
peter@ for
 content/shell/renderer/layout_test/*
 third_party/WebKit/LayoutTests/*

[Yeol Park, 2017-02-27 07:53:17]

This issue is forked from https://codereview.chromium.org/2425703002/.
For Layout tests.

[hta - Chromium, 2017-02-27 08:21:04]

Please modify the broken external test instead of hacking around the problem in
the "expect" file.

https://codereview.chromium.org/2723433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt
(right):

https://codereview.chromium.org/2723433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt:24:
FAIL MediaStreamTrack interface: attribute remote assert_true: The prototype
object must have a property "remote" expected true got false
The correct fix is to instead  modify
wpt/mediacapture-streams/MediaStreamTrack-init.https.html and remove these two
lines:

    readonly    attribute boolean               _readonly;\
    readonly    attribute boolean               remote;\

and then modify the "expected" file accordingly.

According to my current understanding, committing this to Chrome will also get
it upstreamed into the Web Platform Tests repo, so that the fix will be applied
to the tests being run by Firefox, WebKit and Edge, which is a Good Thing.

[Guido Urdaneta, 2017-02-27 15:54:16]

https://codereview.chromium.org/2723433002/diff/20001/content/renderer/media/...
File content/renderer/media/media_stream_audio_source.h (right):

https://codereview.chromium.org/2723433002/diff/20001/content/renderer/media/...
content/renderer/media/media_stream_audio_source.h:146: //
TODO(crbug.com/598704): should be remove is_local_source_ variable.
I don't understand the text of the TODO  (maybe delete the "should be"?).
Also, if the plan is to delete this variable, why not in this CL? Is there a
follow-up CL coming?

[Dirk Pranke, 2017-02-27 22:54:11]

lgtm

[Devlin, 2017-02-27 23:20:46]

extensions lgtm

[Yeol Park, 2017-02-28 00:43:38]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 00:44:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yeol Park, 2017-02-28 02:14:00]

On 2017/02/27 15:54:16, Guido Urdaneta wrote:
>
https://codereview.chromium.org/2723433002/diff/20001/content/renderer/media/...
> File content/renderer/media/media_stream_audio_source.h (right):
> 
>
https://codereview.chromium.org/2723433002/diff/20001/content/renderer/media/...
> content/renderer/media/media_stream_audio_source.h:146: //
> TODO(crbug.com/598704): should be remove is_local_source_ variable.
> I don't understand the text of the TODO  (maybe delete the "should be"?).
> Also, if the plan is to delete this variable, why not in this CL? Is there a
> follow-up CL coming?

Guido Urdaneta :

I think we should remove them 'is_local_source_' and 'is_local_source()'.
(also mcasas :
https://codereview.chromium.org/2425703002/diff/1/content/renderer/media/exte...)
becouse These are have always |local| variable.

but in my opinion, this problem is MediaStreamAudioTrack issue.
I hope create new CL for issue tracking and layout tests, history of
MediaStreamAudioTrack.

If you make new bug ID in crbug.com, I will follow it :)

[miu, 2017-02-28 02:28:34]

On 2017/02/28 02:14:00, Park Yeol wrote:
> On 2017/02/27 15:54:16, Guido Urdaneta wrote:
> >
>
https://codereview.chromium.org/2723433002/diff/20001/content/renderer/media/...
> > File content/renderer/media/media_stream_audio_source.h (right):
> > 
> >
>
https://codereview.chromium.org/2723433002/diff/20001/content/renderer/media/...
> > content/renderer/media/media_stream_audio_source.h:146: //
> > TODO(crbug.com/598704): should be remove is_local_source_ variable.
> > I don't understand the text of the TODO  (maybe delete the "should be"?).
> > Also, if the plan is to delete this variable, why not in this CL? Is there a
> > follow-up CL coming?
> 
> Guido Urdaneta :
> 
> I think we should remove them 'is_local_source_' and 'is_local_source()'.
> (also mcasas :
>
https://codereview.chromium.org/2425703002/diff/1/content/renderer/media/exte...)
> becouse These are have always |local| variable.
> 
> but in my opinion, this problem is MediaStreamAudioTrack issue.
> I hope create new CL for issue tracking and layout tests, history of
> MediaStreamAudioTrack.
> 
> If you make new bug ID in http://crbug.com, I will follow it :)

Note: The only reason MediaStreamAudioSource::is_local_source() exists is for
the tracks. Then, if you walk the code, you'll find the tracks only have it to
provide to a few logging statements and UMA-counting in TrackAudioRenderer
(https://cs.chromium.org/chromium/src/content/renderer/media/track_audio_rende...).

So, if the "Media.LocalRendererSinkStates" UMA can be removed; then everything
else can. If not, you'll have to discuss/implement an alternative approach w/
the owner of that UMA before removing the flag.

[commit-bot: I haz the power, 2017-02-28 04:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 04:28:57]

Dry run: This issue passed the CQ dry run.

[hta - Chromium, 2017-02-28 19:34:50]

lgtm
for wpt changes. (other code previously reviewed)

[aelias_OOO_until_Jul13, 2017-02-28 20:31:40]

public/platform lgtm

[mcasas, 2017-03-07 23:44:43]

On 2017/02/28 20:31:40, aelias wrote:
> public/platform lgtm

peary2@, this CL lgtm, I'll make a bug when it lands to follow
removing is_local_source() etc as per my comment in 
https://codereview.chromium.org/2425703002/diff/1/content/renderer/media/exte...
Thanks!

[emircan, 2017-03-07 23:46:16]

emircan@chromium.org changed reviewers:
- emircan@chromium.org

[haraken, 2017-03-08 09:19:26]

WebKit LGTM

[Devlin, 2017-03-08 15:23:39]

extensions lgtm

[Devlin, 2017-03-08 15:24:20]

Whoops, just saw I already reviewed this a week ago - not sure why it just
cropped up newly in my inbox.  Sorry for the churn.

[hta - Chromium, 2017-03-10 08:41:24]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2017-03-10 08:41:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 08:44:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 08:44:16]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Yeol Park, 2017-03-10 10:16:24]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 10:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 10:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 10:22:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yeol Park, 2017-03-10 11:07:09]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 11:07:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 12:25:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 12:25:06]

Dry run: This issue passed the CQ dry run.

[hta - Chromium, 2017-03-12 19:22:53]

On 2017/03/10 08:44:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
>   ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

Patch failure, but you seem to have all the LGTMs needed.
Please rebase and try again.

[Yeol Park, 2017-03-13 03:30:07]

The CQ bit was checked by peary2@gmail.com

[Yeol Park, 2017-03-13 03:30:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, aelias@chromium.org, rdevlin.cronin@chromium.org,
mcasas@chromium.org, hta@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2723433002/#ps60001
(title: "Fixed unittest")

[commit-bot: I haz the power, 2017-03-13 03:30:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 03:36:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 03:36:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yeol Park, 2017-03-13 09:17:41]

peary2@gmail.com changed reviewers:
+ alexmos@chromium.org, mkwst@chromium.org

[Yeol Park, 2017-03-13 09:18:04]

PTAL :)

alexmos@ for content/public/renderer/*
mkwst@ for
 content/shell/renderer/layout_test/*
 third_party/WebKit/LayoutTests/*

[Guido Urdaneta, 2017-03-13 14:53:06]

https://codereview.chromium.org/2723433002/diff/60001/content/renderer/media/...
File content/renderer/media/media_stream_audio_source.h (right):

https://codereview.chromium.org/2723433002/diff/60001/content/renderer/media/...
content/renderer/media/media_stream_audio_source.h:146: //
TODO(crbug.com/598704): should be remove is_local_source_ variable.
Can you fix the comment?
it is grammatically incorrect as is.

[alexmos, 2017-03-13 16:54:44]

content/public/renderer LGTM

[Mike West, 2017-03-13 20:03:20]

mkwst@chromium.org changed reviewers:
+ haraken@chromium.org, mcasas@chromium.org

[Mike West, 2017-03-13 20:03:21]

LGTM, but you'll need someone from //API_OWNERS to sign off on the
virtual/stable/* changes to layout test expectations.

[Yeol Park, 2017-03-14 02:13:32]

peary2@gmail.com changed reviewers:
+ tkent@chromium.org

[Yeol Park, 2017-03-14 02:14:02]

PTAL :)

tkent@ for
virtual/stable/webexposed/*

On 2017/03/13 20:03:21, Mike West (Slow.) wrote:
> LGTM, but you'll need someone from //API_OWNERS to sign off on the
> virtual/stable/* changes to layout test expectations.

[tkent, 2017-03-14 02:19:25]

lgtm

[Yeol Park, 2017-03-14 05:07:14]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 05:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 06:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 06:31:00]

Dry run: This issue passed the CQ dry run.

[Yeol Park, 2017-03-14 06:37:04]

The CQ bit was checked by peary2@gmail.com

[Yeol Park, 2017-03-14 06:37:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, tkent@chromium.org, aelias@chromium.org,
rdevlin.cronin@chromium.org, mcasas@chromium.org, mkwst@chromium.org,
alexmos@chromium.org, hta@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2723433002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-14 06:37:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 06:43:46]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489473424841090,
"parent_rev": "4d775162580774ccfaed86a8dcf2ac6564198d93", "commit_rev":
"27c39dbef0b07b7cd62fb2476d0f0836115fe672"}

[commit-bot: I haz the power, 2017-03-14 06:44:30]

Description was changed from

==========
Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG=598704
==========

to

==========
Remove |remote| and |readonly| members of MediaStreamTrack.

Spec reference:
http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1

removal was in the February 22, 2016'.
[#321] Remove track attributes "remote" and "readonly" :
https://github.com/w3c/mediacapture-main/pull/321

Intent to Deprecate and Remove :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI

BUG=598704

Review-Url: https://codereview.chromium.org/2723433002
Cr-Commit-Position: refs/heads/master@{#456639}
Committed:
https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f...
==========

[commit-bot: I haz the power, 2017-03-14 06:44:33]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f...

[Guido Urdaneta, 2017-03-22 16:00:44]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2767963002/ by guidou@chromium.org.

The reason for reverting is: Temporarily reverting this CL because it causes a
perf regression. See http://crbug.com/703605.

Will reland once we understand why the regression occurred..