Remove |remote| and |readonly| members of MediaStreamTrack

content/renderer/media/external_media_stream_audio_source.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/external_media_stream_audio_source.h"
 
 namespace content {
 
 ExternalMediaStreamAudioSource::ExternalMediaStreamAudioSource(
     scoped_refptr<media::AudioCapturerSource> source,
     int sample_rate,
     media::ChannelLayout channel_layout,
-    int frames_per_buffer,
-    bool is_remote)
-    : MediaStreamAudioSource(!is_remote), source_(std::move(source)),
+    int frames_per_buffer)
+    : MediaStreamAudioSource(true),

[mcasas, 2016/10/17 18:08:25]

I would say that this parameter ripples through to
MediaStreamAudioSource::is_local_source_ [1], which
is probably made superfluous by this CL, and should
be removed. If that's not done in this CL, please add
a TODO with indication of the bug in that class.

(Note that MediaStreamAudioSource::is_local_source_ 
is  only used for a DVLOG, so probably is safe to 
remove right away).

https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audi...

+      source_(std::move(source)),
       was_started_(false) {
   DVLOG(1)
       << "ExternalMediaStreamAudioSource::ExternalMediaStreamAudioSource()";
   DCHECK(source_.get());
   MediaStreamAudioSource::SetFormat(media::AudioParameters(
       media::AudioParameters::AUDIO_PCM_LOW_LATENCY, channel_layout,
       sample_rate,
       16,  // Legacy parameter (data is always in 32-bit float format).
       frames_per_buffer));
 }
@@ skipping 46 matching lines @@
 }
 
 void ExternalMediaStreamAudioSource::OnCaptureError(const std::string& why) {
   // As of this writing, this method doesn't get called for anything useful,
   // and all other implementors just log the message, but don't disconnect sinks
   // or take any other action. So, just log the error.
   LOG(ERROR) << why;
 }
 
 }  // namespace content