Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2767963002: Revert of Remove |remote| and |readonly| members of MediaStreamTrack. (Closed)

Created:
3 years, 9 months ago by Guido Urdaneta
Modified:
3 years, 9 months ago
CC:
avayvod+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-w3ctests_chromium.org, chfremer+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, eric.carlson_apple.com, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, hongchan, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jochen+watch_chromium.org, kinuko+watch, mac-reviews_chromium.org, mcasas+watch+vc_chromium.org, mcasas+watch+mediastream_chromium.org, miu+watch_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, posciak+watch_chromium.org, Raymond Toy, Srirama, tommyw+watchlist_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove |remote| and |readonly| members of MediaStreamTrack. (patchset #5 id:80001 of https://codereview.chromium.org/2723433002/ ) Reason for revert: Temporarily reverting this CL because it causes a perf regression. See http://crbug.com/703605. Will reland once we understand why the regression occurred. Original issue's description: > Remove |remote| and |readonly| members of MediaStreamTrack. > > Spec reference: > http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 > > removal was in the February 22, 2016'. > [#321] Remove track attributes "remote" and "readonly" : > https://github.com/w3c/mediacapture-main/pull/321 > > Intent to Deprecate and Remove : > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI > > BUG=598704 > > Review-Url: https://codereview.chromium.org/2723433002 > Cr-Commit-Position: refs/heads/master@{#456639} > Committed: https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672 TBR=tkent@chromium.org,aelias@chromium.org,alexmos@chromium.org,bbudge@chromium.org,dpranke@chromium.org,drott@chromium.org,esprehn@chromium.org,haraken@chromium.org,hongchan@chromium.org,hta@chromium.org,mcasas@chromium.org,mkwst@chromium.org,peter@chromium.org,rdevlin.cronin@chromium.org,sergeyu@chromium.org,peary2@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=598704 Review-Url: https://codereview.chromium.org/2767963002 Cr-Commit-Position: refs/heads/master@{#459096} Committed: https://chromium.googlesource.com/chromium/src/+/ad1bc7494fbd31e58569ae50362563e87306e5f5

Patch Set 1 #

Patch Set 2 : resolve rebase conflicts, ASSERT->DCHECK and git cl format to pass presubmit #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -75 lines) Patch
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M content/public/renderer/media_stream_utils.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/public/renderer/media_stream_utils.cc View 1 4 chunks +8 lines, -3 lines 0 comments Download
M content/renderer/media/external_media_stream_audio_source.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/external_media_stream_audio_source.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_source.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capturer_source_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_renderer_sink_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_registry.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/pepper_to_video_track_adapter.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/remote_media_stream_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media_capture_from_element/canvas_capture_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media_recorder/audio_track_recorder_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/shell/test_runner/mock_web_user_media_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/test_runner/mock_webrtc_peer_connection_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt View 1 2 chunks +13 lines, -9 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html View 1 chunk +86 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp View 1 5 chunks +29 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamSource.h View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 27 (18 generated)
Guido Urdaneta
Created Revert of Remove |remote| and |readonly| members of MediaStreamTrack.
3 years, 9 months ago (2017-03-22 16:00:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767963002/1
3 years, 9 months ago (2017-03-22 16:01:10 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/177532) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-22 16:04:18 UTC) #5
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-22 16:20:36 UTC) #6
hta - Chromium
lgtm
3 years, 9 months ago (2017-03-23 10:58:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767963002/310001
3 years, 9 months ago (2017-03-23 13:06:01 UTC) #19
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-23 13:10:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767963002/330001
3 years, 9 months ago (2017-03-23 13:48:33 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:55:43 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:330001) as
https://chromium.googlesource.com/chromium/src/+/ad1bc7494fbd31e58569ae503625...

Powered by Google App Engine
This is Rietveld 408576698