Remove TODOs to remove the "new back shortcut bubble".

Remove TODOs to remove the "new back shortcut bubble".

This feature was put in temporarily to teach users the new shortcut for
back/forward. We decided on the linked bug to keep it indefinitely since
it's a helpful teaching aid, users will only see it a few times, and the
maintenance cost is low.

BUG=610039
Review-Url: https://codereview.chromium.org/2723193003
Cr-Commit-Position: refs/heads/master@{#454807}
Committed: https://chromium.googlesource.com/chromium/src/+/d5f275985e8e58c1ef94444d28b7f9cbc66982dc

[Matt Giuca, 2017-03-01 23:35:51]

mgiuca@chromium.org changed reviewers:
+ grt@chromium.org, pkasting@chromium.org

[Matt Giuca, 2017-03-01 23:35:52]

See discussion on bug from Comment 105 onwards.

https://codereview.chromium.org/2723193003/diff/20001/chrome/app/chrome_comma...
File chrome/app/chrome_command_ids.h (right):

https://codereview.chromium.org/2723193003/diff/20001/chrome/app/chrome_comma...
chrome/app/chrome_command_ids.h:35: // trial is enabled.
Also happy to just delete this comment since no other command has a comment
here.

[Peter Kasting, 2017-03-02 23:28:23]

LGTM

https://codereview.chromium.org/2723193003/diff/20001/chrome/app/chrome_comma...
File chrome/app/chrome_command_ids.h (right):

https://codereview.chromium.org/2723193003/diff/20001/chrome/app/chrome_comma...
chrome/app/chrome_command_ids.h:35: // trial is enabled.
On 2017/03/01 23:35:52, Matt Giuca wrote:
> Also happy to just delete this comment since no other command has a comment
> here.

Yeah, I'd delete this comment, and if this information is not captured
elsewhere, seek to add it elsewhere, e.g. in the command-handling code or
something.

[Matt Giuca, 2017-03-02 23:59:30]

https://codereview.chromium.org/2723193003/diff/20001/chrome/app/chrome_comma...
File chrome/app/chrome_command_ids.h (right):

https://codereview.chromium.org/2723193003/diff/20001/chrome/app/chrome_comma...
chrome/app/chrome_command_ids.h:35: // trial is enabled.
On 2017/03/02 23:28:23, Peter Kasting wrote:
> On 2017/03/01 23:35:52, Matt Giuca wrote:
> > Also happy to just delete this comment since no other command has a comment
> > here.
> 
> Yeah, I'd delete this comment, and if this information is not captured
> elsewhere, seek to add it elsewhere, e.g. in the command-handling code or
> something.

None of the other places where IDC_BACKSPACE_BACK is enumerated seem
comment-friendly either (they're all big tables), except for the switch
statement where it's handled, and that leads you to the well-documented
NewBackShortcutBubble. I'll just delete this then.

[Matt Giuca, 2017-03-02 23:59:34]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2017-03-02 23:59:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2723193003/#ps40001
(title: "Remove comment entirely.")

[commit-bot: I haz the power, 2017-03-03 00:00:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 00:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 00:08:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2017-03-03 10:11:14]

chrome/app lgtm

[Matt Giuca, 2017-03-06 01:03:12]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2017-03-06 01:03:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 01:44:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488762192429180,
"parent_rev": "f82c6edf451db714b211a7c92b9c1ca3547ab0ec", "commit_rev":
"d5f275985e8e58c1ef94444d28b7f9cbc66982dc"}

[commit-bot: I haz the power, 2017-03-06 01:45:45]

Description was changed from

==========
Remove TODOs to remove the "new back shortcut bubble".

This feature was put in temporarily to teach users the new shortcut for
back/forward. We decided on the linked bug to keep it indefinitely since
it's a helpful teaching aid, users will only see it a few times, and the
maintenance cost is low.

BUG=610039
==========

to

==========
Remove TODOs to remove the "new back shortcut bubble".

This feature was put in temporarily to teach users the new shortcut for
back/forward. We decided on the linked bug to keep it indefinitely since
it's a helpful teaching aid, users will only see it a few times, and the
maintenance cost is low.

BUG=610039

Review-Url: https://codereview.chromium.org/2723193003
Cr-Commit-Position: refs/heads/master@{#454807}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5f275985e8e58c1ef94444d28b7...
==========

[commit-bot: I haz the power, 2017-03-06 01:45:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d5f275985e8e58c1ef94444d28b7...