Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: chrome/browser/ui/views/new_back_shortcut_bubble.h

Issue 2723193003: Remove TODOs to remove the "new back shortcut bubble". (Closed)
Patch Set: Remove comment entirely. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_NEW_BACK_SHORTCUT_BUBBLE_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_NEW_BACK_SHORTCUT_BUBBLE_H_
6 #define CHROME_BROWSER_UI_VIEWS_NEW_BACK_SHORTCUT_BUBBLE_H_ 6 #define CHROME_BROWSER_UI_VIEWS_NEW_BACK_SHORTCUT_BUBBLE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/timer/timer.h" 12 #include "base/timer/timer.h"
13 #include "ui/gfx/animation/animation_delegate.h" 13 #include "ui/gfx/animation/animation_delegate.h"
14 14
15 class ExclusiveAccessBubbleViewsContext; 15 class ExclusiveAccessBubbleViewsContext;
16 class SubtleNotificationView; 16 class SubtleNotificationView;
17 17
18 namespace gfx { 18 namespace gfx {
19 class Animation; 19 class Animation;
20 class Rect; 20 class Rect;
21 class SlideAnimation; 21 class SlideAnimation;
22 } 22 }
23 23
24 namespace views { 24 namespace views {
25 class Widget; 25 class Widget;
26 } 26 }
27 27
28 // NewBackShortcutBubble shows a short-lived notification along the top of the 28 // NewBackShortcutBubble shows a short-lived notification along the top of the
29 // screen when the user presses the old Back/Forward shortcut, telling them how 29 // screen when the user presses the old Back/Forward shortcut, telling them how
30 // to use the new shortcut. This will only be available for a few milestones to 30 // to use the new shortcut. This notification only shows up the first few times
31 // let users adapt. 31 // the user presses the old shortcut.
32 // TODO(mgiuca): Remove this in M54 (https://crbug.com/610039).
33 class NewBackShortcutBubble : public gfx::AnimationDelegate { 32 class NewBackShortcutBubble : public gfx::AnimationDelegate {
34 public: 33 public:
35 explicit NewBackShortcutBubble(ExclusiveAccessBubbleViewsContext* context); 34 explicit NewBackShortcutBubble(ExclusiveAccessBubbleViewsContext* context);
36 ~NewBackShortcutBubble() override; 35 ~NewBackShortcutBubble() override;
37 36
38 // Returns whether the UI is currently visible. 37 // Returns whether the UI is currently visible.
39 bool IsVisible() const; 38 bool IsVisible() const;
40 39
41 // Ensures the UI is displaying the correct shortcut for forward/back based on 40 // Ensures the UI is displaying the correct shortcut for forward/back based on
42 // |forward|, and resets the hide timer. 41 // |forward|, and resets the hide timer.
(...skipping 20 matching lines...) Expand all
63 62
64 // The contents of the popup. 63 // The contents of the popup.
65 SubtleNotificationView* const view_; 64 SubtleNotificationView* const view_;
66 65
67 views::Widget* const popup_; 66 views::Widget* const popup_;
68 67
69 DISALLOW_COPY_AND_ASSIGN(NewBackShortcutBubble); 68 DISALLOW_COPY_AND_ASSIGN(NewBackShortcutBubble);
70 }; 69 };
71 70
72 #endif // CHROME_BROWSER_UI_VIEWS_NEW_BACK_SHORTCUT_BUBBLE_H_ 71 #endif // CHROME_BROWSER_UI_VIEWS_NEW_BACK_SHORTCUT_BUBBLE_H_
OLDNEW
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698