Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: chrome/app/chrome_command_ids.h

Issue 2723193003: Remove TODOs to remove the "new back shortcut bubble". (Closed)
Patch Set: Remove TODO and update comment in NewBackShortcutBubble. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/new_back_shortcut_bubble.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_APP_CHROME_COMMAND_IDS_H_ 5 #ifndef CHROME_APP_CHROME_COMMAND_IDS_H_
6 #define CHROME_APP_CHROME_COMMAND_IDS_H_ 6 #define CHROME_APP_CHROME_COMMAND_IDS_H_
7 7
8 // This file lists all the command IDs understood by e.g. the browser. 8 // This file lists all the command IDs understood by e.g. the browser.
9 // It is used by Windows RC files, Mac NIB files, and other platforms too. 9 // It is used by Windows RC files, Mac NIB files, and other platforms too.
10 10
(...skipping 11 matching lines...) Expand all
22 // TODO: Reorder to be in visible order; collapse holes 22 // TODO: Reorder to be in visible order; collapse holes
23 #define IDC_BACK 33000 23 #define IDC_BACK 33000
24 #define IDC_FORWARD 33001 24 #define IDC_FORWARD 33001
25 #define IDC_RELOAD 33002 25 #define IDC_RELOAD 33002
26 #define IDC_HOME 33003 26 #define IDC_HOME 33003
27 #define IDC_OPEN_CURRENT_URL 33004 27 #define IDC_OPEN_CURRENT_URL 33004
28 #define IDC_STOP 33006 28 #define IDC_STOP 33006
29 #define IDC_RELOAD_BYPASSING_CACHE 33007 29 #define IDC_RELOAD_BYPASSING_CACHE 33007
30 #define IDC_LOAD_NEW_TAB_PAGE 33008 30 #define IDC_LOAD_NEW_TAB_PAGE 33008
31 #define IDC_RELOAD_CLEARING_CACHE 33009 31 #define IDC_RELOAD_CLEARING_CACHE 33009
32 // Temporary commands to capture the old Back/Forward shortcuts and tell users 32 // Commands to capture the old Back/Forward shortcuts (which users of old Chrome
33 // the new shortcut. May also trigger Back/Forward action if the 33 // versions or other browsers may be familiar with) and tell users the new
34 // BackspaceGoesBack field trial is enabled. 34 // shortcut. May also trigger Back/Forward action if the BackspaceGoesBack field
35 // TODO(mgiuca): Remove these in M54 (https://crbug.com/610039). 35 // trial is enabled.
Matt Giuca 2017/03/01 23:35:52 Also happy to just delete this comment since no ot
Peter Kasting 2017/03/02 23:28:23 Yeah, I'd delete this comment, and if this informa
Matt Giuca 2017/03/02 23:59:30 None of the other places where IDC_BACKSPACE_BACK
36 #define IDC_BACKSPACE_BACK 33010 36 #define IDC_BACKSPACE_BACK 33010
37 #define IDC_BACKSPACE_FORWARD 33011 37 #define IDC_BACKSPACE_FORWARD 33011
38 38
39 // Window management commands 39 // Window management commands
40 #define IDC_NEW_WINDOW 34000 40 #define IDC_NEW_WINDOW 34000
41 #define IDC_NEW_INCOGNITO_WINDOW 34001 41 #define IDC_NEW_INCOGNITO_WINDOW 34001
42 #define IDC_PIN_TO_START_SCREEN 34005 42 #define IDC_PIN_TO_START_SCREEN 34005
43 #define IDC_CLOSE_WINDOW 34012 43 #define IDC_CLOSE_WINDOW 34012
44 #define IDC_ALWAYS_ON_TOP 34013 44 #define IDC_ALWAYS_ON_TOP 34013
45 #define IDC_NEW_TAB 34014 45 #define IDC_NEW_TAB 34014
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 // See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx 352 // See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx
353 353
354 // Starting command id for menus showing bookmarks (such as the wrench menu). 354 // Starting command id for menus showing bookmarks (such as the wrench menu).
355 // While command ids passed to Windows functions must not be higher than 0xDFFF, 355 // While command ids passed to Windows functions must not be higher than 0xDFFF,
356 // these IDs are not exposed to the native system and thus can be in this 356 // these IDs are not exposed to the native system and thus can be in this
357 // otherwise-reserved range. No command used in a menu (such as the wrench menu) 357 // otherwise-reserved range. No command used in a menu (such as the wrench menu)
358 // should be higher than this, otherwise it'll conflict. 358 // should be higher than this, otherwise it'll conflict.
359 #define IDC_FIRST_BOOKMARK_MENU 0xE000 359 #define IDC_FIRST_BOOKMARK_MENU 0xE000
360 360
361 #endif // CHROME_APP_CHROME_COMMAND_IDS_H_ 361 #endif // CHROME_APP_CHROME_COMMAND_IDS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/new_back_shortcut_bubble.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698