[DevTools] Turn TracingManager into SDKModel.

[DevTools] Turn TracingManager into SDKModel.

This ensures capability check and cleans up some code around mainTarget usage.

BUG=none

Review-Url: https://codereview.chromium.org/2722993002
Cr-Commit-Position: refs/heads/master@{#454055}
Committed: https://chromium.googlesource.com/chromium/src/+/cb16a69fc771ddc62b00da78161c2b55c4385b3a

[dgozman, 2017-03-01 02:05:14]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-03-01 02:05:14]

Could you please take a look?

[caseq, 2017-03-01 02:28:06]

https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:196: Tracing: 128,
nit: these could perhaps be better written as (1 << 7) etc. to emphasize it's a
bit mask.

https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
(right):

https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:234:
var cpuProfile = this._cpuProfiles.get(workerId);
Can we really expect that worker id in trace is same as the target id?

[caseq, 2017-03-01 02:31:46]

On 2017/03/01 02:28:06, caseq wrote:
>
https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
> File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):
> 
>
https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/sdk/Target.js:196: Tracing: 128,
> nit: these could perhaps be better written as (1 << 7) etc. to emphasize it's
a
> bit mask.
> 
>
https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
> File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
> (right):
> 
>
https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
>
third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:234:
> var cpuProfile = this._cpuProfiles.get(workerId);
> Can we really expect that worker id in trace is same as the target id?

Ah, I see it can. lgtm then.

[dgozman, 2017-03-01 20:32:17]

Thank you for review!

https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2722993002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:196: Tracing: 128,
On 2017/03/01 02:28:06, caseq wrote:
> nit: these could perhaps be better written as (1 << 7) etc. to emphasize it's
a
> bit mask.

Done.

[dgozman, 2017-03-01 20:32:24]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-01 20:32:25]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2722993002/#ps20001
(title: "review comment")

[commit-bot: I haz the power, 2017-03-01 20:33:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:01:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488400344866090,
"parent_rev": "13edaa9f1b449a0de7fb6529c5227751668a4ec9", "commit_rev":
"cb16a69fc771ddc62b00da78161c2b55c4385b3a"}

[commit-bot: I haz the power, 2017-03-01 22:04:47]

Description was changed from

==========
[DevTools] Turn TracingManager into SDKModel.

This ensures capability check and cleans up some code around mainTarget usage.

BUG=none
==========

to

==========
[DevTools] Turn TracingManager into SDKModel.

This ensures capability check and cleans up some code around mainTarget usage.

BUG=none

Review-Url: https://codereview.chromium.org/2722993002
Cr-Commit-Position: refs/heads/master@{#454055}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb16a69fc771ddc62b00da78161c...
==========

[commit-bot: I haz the power, 2017-03-01 22:04:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb16a69fc771ddc62b00da78161c...