Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2722993002: [DevTools] Turn TracingManager into SDKModel. (Closed)
Patch Set: review comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
index 0cf6e7523b163d529f099f43a5f300044e48af00..52f19551b75146bdc8f0109192b8b2b61363ea3a 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
@@ -258,9 +258,6 @@ SDK.TargetManager = class extends Common.Object {
target.model(SDK.DOMModel);
target.model(SDK.CSSModel);
target.model(SDK.CPUProfilerModel);
-
- target.tracingManager = new SDK.TracingManager(target);
-
target.model(SDK.ServiceWorkerManager);
if (target.hasTargetCapability())
@@ -406,7 +403,7 @@ SDK.TargetManager = class extends Common.Object {
var capabilities = SDK.Target.Capability.Browser | SDK.Target.Capability.DOM | SDK.Target.Capability.JS |
SDK.Target.Capability.Log | SDK.Target.Capability.Network | SDK.Target.Capability.Target |
- SDK.Target.Capability.ScreenCapture;
+ SDK.Target.Capability.ScreenCapture | SDK.Target.Capability.Tracing;
if (Runtime.queryParam('isSharedWorker')) {
capabilities = SDK.Target.Capability.Browser | SDK.Target.Capability.Log | SDK.Target.Capability.Network |
SDK.Target.Capability.Target;
@@ -520,7 +517,8 @@ SDK.ChildTargetManager = class {
return SDK.Target.Capability.Log | SDK.Target.Capability.Network | SDK.Target.Capability.Target;
if (type === 'iframe') {
return SDK.Target.Capability.Browser | SDK.Target.Capability.DOM | SDK.Target.Capability.JS |
- SDK.Target.Capability.Log | SDK.Target.Capability.Network | SDK.Target.Capability.Target;
+ SDK.Target.Capability.Log | SDK.Target.Capability.Network | SDK.Target.Capability.Target |
+ SDK.Target.Capability.Tracing;
}
if (type === 'node')
return SDK.Target.Capability.JS;

Powered by Google App Engine
This is Rietveld 408576698