[DevTools] Access cpu profiler only when JS capability is present.

[DevTools] Access cpu profiler only when JS capability is present.

This patch:
- removes direct access to profilerAgent;
- only creates CPUProfilerModel when JS capability is present;
- migrates some target observers to CPUProfilerModel observers;
- sets sampling interval immediately before recording.

BUG=none

Review-Url: https://codereview.chromium.org/2721663005
Cr-Commit-Position: refs/heads/master@{#453804}
Committed: https://chromium.googlesource.com/chromium/src/+/ef373c14dc822c44badfd7a359cdb87b631d1a27

[dgozman, 2017-02-28 23:05:39]

dgozman@chromium.org changed reviewers:
+ alph@chromium.org

[dgozman, 2017-02-28 23:05:39]

Take a look please.

[dgozman, 2017-02-28 23:05:42]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:06:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:10:21]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[alph, 2017-02-28 23:59:13]

lgtm

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
(right):

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js:233:
.target()
nit: I'd rather write the synchronous part in a single line.

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js
(right):

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js:93: *
@return {!Promise}
Why promise? It's a sync function

[dgozman, 2017-03-01 00:18:41]

Thank you for review!

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
(right):

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js:233:
.target()
On 2017/02/28 23:59:13, alph wrote:
> nit: I'd rather write the synchronous part in a single line.

That's what I did, but formatter thinks differently.

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js
(right):

https://codereview.chromium.org/2721663005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js:93: *
@return {!Promise}
On 2017/02/28 23:59:13, alph wrote:
> Why promise? It's a sync function

Correct, removed the promise.

[dgozman, 2017-03-01 00:22:07]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-03-01 00:22:07]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2721663005/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-03-01 00:22:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:25:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2017-03-01 01:34:27]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:35:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:58:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488332067195270,
"parent_rev": "c1da30bf485aad6bb1fda929b830467898495370", "commit_rev":
"ef373c14dc822c44badfd7a359cdb87b631d1a27"}

[commit-bot: I haz the power, 2017-03-01 02:59:16]

Description was changed from

==========
[DevTools] Access cpu profiler only when JS capability is present.

This patch:
- removes direct access to profilerAgent;
- only creates CPUProfilerModel when JS capability is present;
- migrates some target observers to CPUProfilerModel observers;
- sets sampling interval immediately before recording.

BUG=none
==========

to

==========
[DevTools] Access cpu profiler only when JS capability is present.

This patch:
- removes direct access to profilerAgent;
- only creates CPUProfilerModel when JS capability is present;
- migrates some target observers to CPUProfilerModel observers;
- sets sampling interval immediately before recording.

BUG=none

Review-Url: https://codereview.chromium.org/2721663005
Cr-Commit-Position: refs/heads/master@{#453804}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef373c14dc822c44badfd7a359cd...
==========

[commit-bot: I haz the power, 2017-03-01 02:59:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ef373c14dc822c44badfd7a359cd...