third_party/WebKit/Source/core/css/resolver/StyleResolver.h - Issue 2722983004: Use ApplyAnimations enum parameter instead of bool for callsite readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.h

Issue 2722983004: Use ApplyAnimations enum parameter instead of bool for callsite readability (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.h

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.h b/third_party/WebKit/Source/core/css/resolver/StyleResolver.h

index 667d93ca4267b3cbaf4ad090c0db2f423de3de60..0d601f459d31499ed2e713c5c7439757e8f7e03b 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.h

+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.h

@@ -244,9 +244,10 @@ class CORE_EXPORT StyleResolver final

const MatchResult&,

const Element* animatingElement);

CacheSuccess applyMatchedCache(StyleResolverState&, const MatchResult&);

+ enum ApplyAnimations { ExcludeAnimations, IncludeAnimations };

void applyCustomProperties(StyleResolverState&,

const MatchResult&,

- bool applyAnimations,

+ ApplyAnimations,

const CacheSuccess&,

NeedsApplyPass&);

void applyMatchedAnimationProperties(StyleResolverState&,

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »