Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2722983004: Use ApplyAnimations enum parameter instead of bool for callsite readability (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index c4e95bcc8ee98a914eb5d4330ad7e44fc7dbcf97..f7e938460cbf8fdbe46f7c75729baf5a952e02ad 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -1606,7 +1606,7 @@ void StyleResolver::applyMatchedPropertiesAndCustomPropertyAnimations(
CacheSuccess cacheSuccess = applyMatchedCache(state, matchResult);
NeedsApplyPass needsApplyPass;
if (!cacheSuccess.isFullCacheHit()) {
- applyCustomProperties(state, matchResult, false, cacheSuccess,
+ applyCustomProperties(state, matchResult, ExcludeAnimations, cacheSuccess,
needsApplyPass);
applyMatchedAnimationProperties(state, matchResult, cacheSuccess,
needsApplyPass);
@@ -1616,7 +1616,7 @@ void StyleResolver::applyMatchedPropertiesAndCustomPropertyAnimations(
calculateAnimationUpdate(state, animatingElement);
if (state.isAnimatingCustomProperties()) {
cacheSuccess.setFailed();
- applyCustomProperties(state, matchResult, true, cacheSuccess,
+ applyCustomProperties(state, matchResult, IncludeAnimations, cacheSuccess,
needsApplyPass);
}
}
@@ -1686,7 +1686,7 @@ StyleResolver::CacheSuccess StyleResolver::applyMatchedCache(
void StyleResolver::applyCustomProperties(StyleResolverState& state,
const MatchResult& matchResult,
- bool applyAnimations,
+ ApplyAnimations applyAnimations,
const CacheSuccess& cacheSuccess,
NeedsApplyPass& needsApplyPass) {
DCHECK(!cacheSuccess.isFullCacheHit());
@@ -1700,7 +1700,7 @@ void StyleResolver::applyCustomProperties(StyleResolverState& state,
applyMatchedProperties<ResolveVariables, CheckNeedsApplyPass>(
state, matchResult.authorRules(), true, applyInheritedOnly,
needsApplyPass);
- if (applyAnimations) {
+ if (applyAnimations == IncludeAnimations) {
applyAnimatedProperties<ResolveVariables>(
state, state.animationUpdate().activeInterpolationsForAnimations());
}
@@ -1716,7 +1716,7 @@ void StyleResolver::applyCustomProperties(StyleResolverState& state,
applyMatchedProperties<ResolveVariables, CheckNeedsApplyPass>(
state, matchResult.authorRules(), true, applyInheritedOnly,
needsApplyPass);
- if (applyAnimations) {
+ if (applyAnimations == IncludeAnimations) {
applyAnimatedProperties<ResolveVariables>(
state, state.animationUpdate().activeInterpolationsForAnimations());
}
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698