Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm

Issue 2722783003: Separate deletion button in password settings (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
index 112b9623e19600e4649b858f95e443ddf375d039..52dd9cd13017516ed265fb4f4d4797731dc13560 100644
--- a/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
@@ -82,7 +82,9 @@ const int kPasswordSection = 2;
const int kPasswordItem = 0;
const int kShowHideButtonItem = 1;
const int kCopyPasswordButtonItem = 2;
-const int kDeleteButtonItem = 3;
+
+const int kDeleteSection = 3;
+const int kDeleteButtonItem = 0;
class PasswordDetailsCollectionViewControllerTest
: public CollectionViewControllerTest {
@@ -125,7 +127,7 @@ class PasswordDetailsCollectionViewControllerTest
TEST_F(PasswordDetailsCollectionViewControllerTest, TestInitialization) {
CreateController();
CheckController();
- EXPECT_EQ(3, NumberOfSections());
+ EXPECT_EQ(4, NumberOfSections());
// Site section
EXPECT_EQ(2, NumberOfItemsInSection(kUsernameSection));
CheckSectionHeaderWithId(IDS_IOS_SHOW_PASSWORD_VIEW_SITE, kSiteSection);
@@ -146,7 +148,7 @@ TEST_F(PasswordDetailsCollectionViewControllerTest, TestInitialization) {
CheckTextCellTitleWithId(IDS_IOS_SETTINGS_USERNAME_COPY_BUTTON,
kUsernameSection, kCopyUsernameButtonItem);
// Password section
- EXPECT_EQ(4, NumberOfItemsInSection(kPasswordSection));
+ EXPECT_EQ(3, NumberOfItemsInSection(kPasswordSection));
CheckSectionHeaderWithId(IDS_IOS_SHOW_PASSWORD_VIEW_PASSWORD,
kPasswordSection);
PasswordDetailsItem* passwordItem =
@@ -157,8 +159,10 @@ TEST_F(PasswordDetailsCollectionViewControllerTest, TestInitialization) {
kPasswordSection, kShowHideButtonItem);
CheckTextCellTitleWithId(IDS_IOS_SETTINGS_PASSWORD_COPY_BUTTON,
kPasswordSection, kCopyPasswordButtonItem);
+ // Delete section
+ EXPECT_EQ(1, NumberOfItemsInSection(kDeleteSection));
CheckTextCellTitleWithId(IDS_IOS_SETTINGS_PASSWORD_DELETE_BUTTON,
- kPasswordSection, kDeleteButtonItem);
+ kDeleteSection, kDeleteButtonItem);
}
struct SimplifyOriginTestData {
@@ -251,7 +255,7 @@ TEST_F(PasswordDetailsCollectionViewControllerTest, DeletePassword) {
CreateController();
[controller() collectionView:[controller() collectionView]
didSelectItemAtIndexPath:[NSIndexPath indexPathForRow:kDeleteButtonItem
- inSection:kPasswordSection]];
+ inSection:kDeleteSection]];
EXPECT_EQ(1, delegate_.numberOfCallsToDeletePassword);
}
« no previous file with comments | « ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698