Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2722623002: Fix a crash when setting MediaControlsEnabled setting for videos without controls (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash when setting MediaControlsEnabled setting for videos without controls There's a crash which is triggered when we set MediaControlsEnabled setting before the video controls get created. This CL adds null-check before calling MediaControls::onMediaControlsEnabledChange(). BUG=696645 Review-Url: https://codereview.chromium.org/2722623002 Cr-Commit-Position: refs/heads/master@{#453595} Committed: https://chromium.googlesource.com/chromium/src/+/e48ec244742e350bb55ad07dde1150022c536f84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-02-27 18:42:36 UTC) #2
mlamouri (slow - plz ping)
lgtm
3 years, 9 months ago (2017-02-28 14:30:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722623002/1
3 years, 9 months ago (2017-02-28 14:30:25 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 14:34:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e48ec244742e350bb55ad07dde11...

Powered by Google App Engine
This is Rietveld 408576698