Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html

Issue 2722623002: Fix a crash when setting MediaControlsEnabled setting for videos without controls (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html
diff --git a/third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html b/third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html
index 5bd7c1153b9c6336874176f480d5a99156bb40fa..2aac53bc4cacfdbd8a94bb46d3e99f37f62912e7 100644
--- a/third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html
+++ b/third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html
@@ -6,6 +6,11 @@
<script src="../media-controls.js"></script>
<video controls></video>
<script>
+// |orphanedVideo| is used to check that the setting should not be despatched
+// if the MediaControls of a video haven't been initialized.
+var orphanedVideo = document.createElement('video');
+orphanedVideo.controls = true;
+
async_test(t => {
var video = document.querySelector('video');
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698