third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html - Issue 2722623002: Fix a crash when setting MediaControlsEnabled setting for videos without controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls/settings-disable-controls.html

Issue 2722623002: Fix a crash when setting MediaControlsEnabled setting for videos without controls (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Test that 'mediaControlsEnabled' properly toggles the native controls</ti tle>	2 <title>Test that 'mediaControlsEnabled' properly toggles the native controls</ti tle>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script src="../media-file.js"></script>	5 <script src="../media-file.js"></script>

6 <script src="../media-controls.js"></script>	6 <script src="../media-controls.js"></script>

7 <video controls></video>	7 <video controls></video>

8 <script>	8 <script>

	9 // \|orphanedVideo\| is used to check that the setting should not be despatched

	10 // if the MediaControls of a video haven't been initialized.

	11 var orphanedVideo = document.createElement('video');

	12 orphanedVideo.controls = true;

	13

9 async_test(t => {	14 async_test(t => {

10 var video = document.querySelector('video');	15 var video = document.querySelector('video');

11	16

12 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);	17 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

13 t.add_cleanup(() => {	18 t.add_cleanup(() => {

14 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, false);	19 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, false);

15 });	20 });

16	21

17 video.addEventListener('canplaythrough', t.step_func(e => {	22 video.addEventListener('canplaythrough', t.step_func(e => {

18 assert_equals(overlayCastButton(video).style.display, "none");	23 assert_equals(overlayCastButton(video).style.display, "none");

19 assert_not_equals(mediaControlsButton(video, "panel").style.display, "none") ;	24 assert_not_equals(mediaControlsButton(video, "panel").style.display, "none") ;

20	25

21 internals.settings.setMediaControlsEnabled(false);	26 internals.settings.setMediaControlsEnabled(false);

22 testRunner.layoutAndPaintAsyncThen(t.step_func(() => {	27 testRunner.layoutAndPaintAsyncThen(t.step_func(() => {

23 assert_equals(mediaControlsButton(video, "panel").style.display, "none");	28 assert_equals(mediaControlsButton(video, "panel").style.display, "none");

24 assert_equals(overlayCastButton(video).style.display, "none");	29 assert_equals(overlayCastButton(video).style.display, "none");

25	30

26 internals.settings.setMediaControlsEnabled(true);	31 internals.settings.setMediaControlsEnabled(true);

27 testRunner.layoutAndPaintAsyncThen(t.step_func_done(() => {	32 testRunner.layoutAndPaintAsyncThen(t.step_func_done(() => {

28 assert_not_equals(mediaControlsButton(video, "panel").style.display, "no ne");	33 assert_not_equals(mediaControlsButton(video, "panel").style.display, "no ne");

29 assert_equals(overlayCastButton(video).style.display, "none");	34 assert_equals(overlayCastButton(video).style.display, "none");

30 }));	35 }));

31 }));	36 }));

32 }));	37 }));

33	38

34 video.src = findMediaFile('video', '../content/test');	39 video.src = findMediaFile('video', '../content/test');

35 });	40 });

36 </script>	41 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »