third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html - Issue 2721663005: [DevTools] Access cpu profiler only when JS capability is present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html

Issue 2721663005: [DevTools] Access cpu profiler only when JS capability is present. (Closed)

Patch Set: rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-stopped-removed-race.html ('k') | third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html b/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html

index 64e408d44d34139697a71f321627db1aaec26339..6bc552f711878a216637ac57256c89795de917ea 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html

@@ -287,7 +287,7 @@ function test()

};

var timelineController = InspectorTest.timelineController();

- timelineController._addCpuProfile(SDK.targetManager.mainTarget().id(), null, cpuProfile);

+ timelineController._addCpuProfile(SDK.targetManager.mainTarget().id(), cpuProfile);

timelineController.traceEventsCollected(rawTraceEvents);

timelineController._finalizeTrace();

var events = timelineController._performanceModel.timelineModel().inspectedTargetEvents();