Remove Port.default_pixel_tests.

Remove Port.default_pixel_tests.

Reason: default_pixel_tests always returns True for all ports;
this is not port-specific behavior now.

BUG=677561
Review-Url: https://codereview.chromium.org/2721603003
Cr-Commit-Position: refs/heads/master@{#454778}
Committed: https://chromium.googlesource.com/chromium/src/+/89ddac7ace76af94a072f74d465968f55f969d59

[qyearsley, 2017-02-27 19:12:20]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 19:12:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 20:15:29]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-02-27 21:12:27]

qyearsley@chromium.org changed reviewers:
+ ojan@chromium.org

[qyearsley, 2017-02-27 21:12:27]

Hi Ojan, I just noticed this method that doesn't appear
very useful right now in layout test Port class; I was
wondering if you could remember any particular reason
that I don't know about why this should be kept?

This is a non-urgent CL that shouldn't affect behavior.

[qyearsley, 2017-03-02 20:07:29]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-03-02 20:07:30]

Adding Jeff as reviewer; this CL probably doesn't require Ojan's review, so if
there are no objections then it's probably OK to commit.

[jeffcarp, 2017-03-03 23:35:29]

lgtm

[qyearsley, 2017-03-03 23:41:59]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-03-03 23:42:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 01:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 01:05:32]

Failed to apply patch for
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py:430
  error: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py:
patch does not apply

Patch:       third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
index
505a3f87ecc4118ad14a94511e3478da4e1daeed..a49652b3dce03324614a3d8678f4251de732f546
100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
@@ -430,9 +430,6 @@ class TestPort(Port):
     def buildbot_archives_baselines(self):
         return self._name != 'test-win-win7'
 
-    def default_pixel_tests(self):
-        return True
-
     def _path_to_driver(self):
         # This routine shouldn't normally be called, but it is called by
         # the mock_drt Driver. We return something, but make sure it's useless.

[qyearsley, 2017-03-04 18:50:12]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 18:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-03-04 19:00:07]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2017-03-04 19:00:09]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-03-04 19:00:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2721603003/#ps40001
(title: "Remove Port.default_pixel_tests.")

[commit-bot: I haz the power, 2017-03-04 19:00:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 19:55:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488654009013600,
"parent_rev": "2db55a16ab3ef68261da87bbafc2b849502e22e4", "commit_rev":
"89ddac7ace76af94a072f74d465968f55f969d59"}

[commit-bot: I haz the power, 2017-03-04 19:55:54]

Description was changed from

==========
Remove Port.default_pixel_tests.

Reason: default_pixel_tests always returns True for all ports;
this is not port-specific behavior now.

BUG=677561
==========

to

==========
Remove Port.default_pixel_tests.

Reason: default_pixel_tests always returns True for all ports;
this is not port-specific behavior now.

BUG=677561

Review-Url: https://codereview.chromium.org/2721603003
Cr-Commit-Position: refs/heads/master@{#454778}
Committed:
https://chromium.googlesource.com/chromium/src/+/89ddac7ace76af94a072f74d4659...
==========

[commit-bot: I haz the power, 2017-03-04 19:55:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/89ddac7ace76af94a072f74d4659...