Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2721603003: Remove Port.default_pixel_tests. (Closed)
Patch Set: Remove Port.default_pixel_tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 self._name, self._version, self._architecture, self._test_configurat ion) 192 self._name, self._version, self._architecture, self._test_configurat ion)
193 193
194 def additional_driver_flag(self): 194 def additional_driver_flag(self):
195 if self.driver_name() == self.CONTENT_SHELL_NAME: 195 if self.driver_name() == self.CONTENT_SHELL_NAME:
196 return ['--run-layout-test'] 196 return ['--run-layout-test']
197 return [] 197 return []
198 198
199 def supports_per_test_timeout(self): 199 def supports_per_test_timeout(self):
200 return False 200 return False
201 201
202 def default_pixel_tests(self):
203 return True
204
205 def default_smoke_test_only(self): 202 def default_smoke_test_only(self):
206 return False 203 return False
207 204
208 def default_timeout_ms(self): 205 def default_timeout_ms(self):
209 timeout_ms = 6 * 1000 206 timeout_ms = 6 * 1000
210 if self.get_option('configuration') == 'Debug': 207 if self.get_option('configuration') == 'Debug':
211 # Debug is usually 2x-3x slower than Release. 208 # Debug is usually 2x-3x slower than Release.
212 return 3 * timeout_ms 209 return 3 * timeout_ms
213 return timeout_ms 210 return timeout_ms
214 211
(...skipping 1420 matching lines...) Expand 10 before | Expand all | Expand 10 after
1635 1632
1636 def __init__(self, base, args, reference_args=None): 1633 def __init__(self, base, args, reference_args=None):
1637 self.name = base 1634 self.name = base
1638 self.base = base 1635 self.base = base
1639 self.args = args 1636 self.args = args
1640 self.reference_args = args if reference_args is None else reference_args 1637 self.reference_args = args if reference_args is None else reference_args
1641 self.tests = set() 1638 self.tests = set()
1642 1639
1643 def __repr__(self): 1640 def __repr__(self):
1644 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1641 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698