Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2721603003: Remove Port.default_pixel_tests. (Closed)
Patch Set: Remove Port.default_pixel_tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index 7e7bd00b0d0f0a1f5fb26aa48f48e01793b2ae4d..113c3d36fc880660bbb123ee1f94f294abb38fe6 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -190,12 +190,14 @@ def parse_args(args):
"--pixel-tests",
dest="pixel_tests",
action="store_true",
- help="Enable pixel-to-pixel PNG comparisons"),
+ default=True,
+ help="Enable pixel-to-pixel PNG comparisons (enabled by default)"),
optparse.make_option(
"--no-pixel",
"--no-pixel-tests",
dest="pixel_tests",
action="store_false",
+ default=True,
help="Disable pixel-to-pixel PNG comparisons"),
# FIXME: we should support a comma separated list with
# --pixel-test-directory as well.
@@ -485,9 +487,6 @@ def _set_up_derived_options(port, options, args):
if not options.configuration:
options.configuration = port.default_configuration()
- if options.pixel_tests is None:
- options.pixel_tests = port.default_pixel_tests()
-
if not options.time_out_ms:
options.time_out_ms = str(port.default_timeout_ms())
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698