third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-garbage-collection-ran-during-error.html - Issue 2721233002: bluetooth: Better disconnected error messages for characteristic retrieval.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-garbage-collection-ran-during-error.html

Issue 2721233002: bluetooth: Better disconnected error messages for characteristic retrieval. (Closed)

Patch Set: Address dcheng's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/disconnect-called-during.html ('k') | third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-garbage-collection-ran-during-success.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!-- Generated by //third_party/WebKit/LayoutTests/bluetooth/generate.py -->	1 <!-- Generated by //third_party/WebKit/LayoutTests/bluetooth/generate.py -->

2 <!DOCTYPE html>	2 <!DOCTYPE html>

3 <script src="../../../resources/testharness.js"></script>	3 <script src="../../../resources/testharness.js"></script>

4 <script src="../../../resources/testharnessreport.js"></script>	4 <script src="../../../resources/testharnessreport.js"></script>

5 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	5 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

6 <script>	6 <script>

7 'use strict';	7 'use strict';

8 promise_test(() => {	8 promise_test(() => {

9 let promise;	9 let promise;

10 return setBluetoothFakeAdapter('MissingCharacteristicHeartRateAdapter')	10 return setBluetoothFakeAdapter('MissingCharacteristicHeartRateAdapter')

11 .then(() => requestDeviceWithKeyDown({	11 .then(() => requestDeviceWithKeyDown({

12 filters: [{services: ['heart_rate']}]}))	12 filters: [{services: ['heart_rate']}]}))

13 .then(device => device.gatt.connect())	13 .then(device => device.gatt.connect())

14 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	14 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

15 .then(service => {	15 .then(service => {

16 promise = assert_promise_rejects_with_message(	16 promise = assert_promise_rejects_with_message(

17 service.getCharacteristic('measurement_interval'),	17 service.getCharacteristic('measurement_interval'),

18 new DOMException(	18 new DOMException(

19 'GATT Server disconnected while retrieving characteristics.',	19 'GATT Server is disconnected. Cannot retrieve characteristics. ' +

	20 '(Re)connect first with `device.gatt.connect`.',

20 'NetworkError'));	21 'NetworkError'));

21 // Disconnect called to clear attributeInstanceMap and allow the	22 // Disconnect called to clear attributeInstanceMap and allow the

22 // object to get garbage collected.	23 // object to get garbage collected.

23 service.device.gatt.disconnect();	24 service.device.gatt.disconnect();

24 })	25 })

25 .then(runGarbageCollection)	26 .then(runGarbageCollection)

26 .then(() => promise);	27 .then(() => promise);

27 }, 'Garbage Collection ran during getCharacteristic call that fails. ' +	28 }, 'Garbage Collection ran during getCharacteristic call that fails. ' +

28 'Should not crash');	29 'Should not crash');

29	30

30 </script>	31 </script>

OLD	NEW