third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/disconnect-called-before.html - Issue 2721233002: bluetooth: Better disconnected error messages for characteristic retrieval.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/disconnect-called-before.html

Issue 2721233002: bluetooth: Better disconnected error messages for characteristic retrieval. (Closed)

Patch Set: Address dcheng's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-disconnects-during-with-uuid.html ('k') | third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/disconnect-called-before-with-uuid.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}]}))	10 filters: [{services: ['heart_rate']}]}))

11 .then(device => device.gatt.connect())	11 .then(device => device.gatt.connect())

12 .then(gattServer => {	12 .then(gattServer => {

13 return gattServer.getPrimaryService('heart_rate')	13 return gattServer.getPrimaryService('heart_rate')

14 .then(heart_rate_service => {	14 .then(heart_rate_service => {

15 gattServer.disconnect();	15 gattServer.disconnect();

16 return assert_promise_rejects_with_message(	16 return assert_promise_rejects_with_message(

17 heart_rate_service.getCharacteristics(),	17 heart_rate_service.getCharacteristics(),

18 new DOMException(	18 new DOMException(

19 'GATT Server is disconnected. Cannot retrieve characteristics.',	19 'GATT Server is disconnected. Cannot retrieve characteristics. ' +

	20 '(Re)connect first with `device.gatt.connect`.',

20 'NetworkError'));	21 'NetworkError'));

21 });	22 });

22 });	23 });

23 }, 'disconnect() called before getCharacteristics. Reject with NetworkError.');	24 }, 'disconnect() called before getCharacteristics. Reject with NetworkError.');

24 </script>	25 </script>

OLD	NEW