Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2720933003: Removed FrameHost::useCounter() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed FrameHost::useCounter() Removed the FrameHost::useCounter() method, and redirected calls to Page::useCounter() using FrameHost's Page reference (or directly on the Page object if it is available). This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2720933003 Cr-Commit-Position: refs/heads/master@{#453524} Committed: https://chromium.googlesource.com/chromium/src/+/a9a9d43c56e9b272cec3c46eb9864d515dacdbaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -37 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSLazyParsingTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 4 chunks +10 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
sashab
PTAL joel :-)
3 years, 9 months ago (2017-02-28 03:56:30 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-02-28 03:59:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720933003/1
3 years, 9 months ago (2017-02-28 06:22:16 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 06:28:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9a9d43c56e9b272cec3c46eb986...

Powered by Google App Engine
This is Rietveld 408576698