Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 2720213002: Removed FrameHost::deprecation() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed FrameHost::deprecation() Removed the FrameHost::deprecation() method, and redirected calls to Page::deprecation() using FrameHost's Page reference (or directly on the Page object if it is available). Also preemptively removed some nearby FrameHost::useCounter() calls, and removed now-redundant FrameHost.h includes. This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2720213002 Cr-Commit-Position: refs/heads/master@{#453519} Committed: https://chromium.googlesource.com/chromium/src/+/49faab2e95fdb5f6cb63788ac6212676558402bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -30 lines) Patch
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounterTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 3 chunks +8 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
sashab
3 years, 9 months ago (2017-02-28 03:55:32 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-02-28 03:58:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720213002/1
3 years, 9 months ago (2017-02-28 04:01:46 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 06:17:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49faab2e95fdb5f6cb63788ac621...

Powered by Google App Engine
This is Rietveld 408576698