Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2720583003: webview: Fix a wrong dependency exposed by https://codereview.chromium.org/2712513004 (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webview: Fix a wrong dependency exposed by https://codereview.chromium.org/2712513004 aw_contents_client_bridge.cc used to include grit/components_strings.h. Before the qualified include, this accidentally picked up the wrong components_strings.h via the wrong dep added in https://codereview.chromium.org/1714573002/ BUG=695936 Review-Url: https://codereview.chromium.org/2720583003 Cr-Commit-Position: refs/heads/master@{#453349} Committed: https://chromium.googlesource.com/chromium/src/+/27b5f24be870a6612160bed7baff48ceae2db8ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/native/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Nico
3 years, 9 months ago (2017-02-27 15:16:09 UTC) #3
Nico
adding an in-timezone reviewer since people on the bug are asking me to land this ...
3 years, 9 months ago (2017-02-27 18:37:03 UTC) #8
David Trainor- moved to gerrit
+boliu@
3 years, 9 months ago (2017-02-27 21:40:17 UTC) #10
boliu
lgtm
3 years, 9 months ago (2017-02-27 21:40:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720583003/1
3 years, 9 months ago (2017-02-27 21:44:51 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 21:55:29 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27b5f24be870a6612160bed7baff...

Powered by Google App Engine
This is Rietveld 408576698