Use a qualified path for grit-generated headers in components/

Use a qualified path for grit-generated headers in components/

The gn and (many!) DEPS changes were lovingly hand-crafted.

The cc changes were done with bash invocations similar to the others
mentioned in the bug.

BUG=401588
Review-Url: https://codereview.chromium.org/2712513004
Cr-Commit-Position: refs/heads/master@{#452591}
Committed: https://chromium.googlesource.com/chromium/src/+/fe8fa0acd8a31887338bbb2b408c2860424d0e8c

[Nico, 2017-02-22 20:20:16]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-02-22 20:21:10]

Description was changed from

==========
Use a qualified path for grit-generated headers in components/

BUG=401588
==========

to

==========
Use a qualified path for grit-generated headers in components/

The gn and (many!) DEPS changes were lovingly hand-crafted.

The cc changes were done with bash invocations similar to the others
mentioned in the bug.

BUG=401588
==========

[commit-bot: I haz the power, 2017-02-22 20:21:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-22 20:26:34]

thakis@chromium.org changed reviewers:
+ sdefresne@chromium.org, torne@chromium.org

[Nico, 2017-02-22 20:26:35]

torne: android_webview
sdefresne: components

[commit-bot: I haz the power, 2017-02-22 20:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:33:58]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nico, 2017-02-22 20:54:43]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 20:55:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 21:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 21:07:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nico, 2017-02-22 21:17:52]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 21:18:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 23:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 23:59:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sdefresne, 2017-02-23 11:34:53]

components/ lgtm

linux_chromium_rel_ng is not happy about checkdeps though

https://codereview.chromium.org/2712513004/diff/40001/components/search_engin...
File components/search_engines/DEPS (right):

https://codereview.chromium.org/2712513004/diff/40001/components/search_engin...
components/search_engines/DEPS:18:
"+components/strings/grit/components_strings.h",
nit: sort

https://codereview.chromium.org/2712513004/diff/40001/components/security_int...
File components/security_interstitials/DEPS (right):

https://codereview.chromium.org/2712513004/diff/40001/components/security_int...
components/security_interstitials/DEPS:9:
"+components/strings/grit/components_strings.h",
nit: sort

https://codereview.chromium.org/2712513004/diff/40001/components/supervised_u...
File
components/supervised_user_error_page/supervised_user_error_page_unittest.cc
(right):

https://codereview.chromium.org/2712513004/diff/40001/components/supervised_u...
components/supervised_user_error_page/supervised_user_error_page_unittest.cc:6:
#include "base/strings/utf_string_conversions.h"
nit: can you add a blank line here?

[Torne, 2017-02-23 12:06:51]

android_webview LGTM

[Nico, 2017-02-23 16:57:53]

Thanks!

https://codereview.chromium.org/2712513004/diff/40001/components/search_engin...
File components/search_engines/DEPS (right):

https://codereview.chromium.org/2712513004/diff/40001/components/search_engin...
components/search_engines/DEPS:18:
"+components/strings/grit/components_strings.h",
On 2017/02/23 11:34:52, sdefresne wrote:
> nit: sort

Done.

https://codereview.chromium.org/2712513004/diff/40001/components/security_int...
File components/security_interstitials/DEPS (right):

https://codereview.chromium.org/2712513004/diff/40001/components/security_int...
components/security_interstitials/DEPS:9:
"+components/strings/grit/components_strings.h",
On 2017/02/23 11:34:52, sdefresne wrote:
> nit: sort

Done.

https://codereview.chromium.org/2712513004/diff/40001/components/supervised_u...
File
components/supervised_user_error_page/supervised_user_error_page_unittest.cc
(right):

https://codereview.chromium.org/2712513004/diff/40001/components/supervised_u...
components/supervised_user_error_page/supervised_user_error_page_unittest.cc:6:
#include "base/strings/utf_string_conversions.h"
On 2017/02/23 11:34:53, sdefresne wrote:
> nit: can you add a blank line here?

Done.

[Nico, 2017-02-23 16:58:01]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-02-23 16:58:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2712513004/#ps60001
(title: "comments")

[commit-bot: I haz the power, 2017-02-23 16:58:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-23 18:16:55]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-02-23 18:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2712513004/#ps80001
(title: "more checkdeps")

[commit-bot: I haz the power, 2017-02-23 18:17:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:46:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487873815352120,
"parent_rev": "62514bb6d6cfe433a87cdd1faed4fbcdfc789859", "commit_rev":
"fe8fa0acd8a31887338bbb2b408c2860424d0e8c"}

[commit-bot: I haz the power, 2017-02-23 19:47:19]

Description was changed from

==========
Use a qualified path for grit-generated headers in components/

The gn and (many!) DEPS changes were lovingly hand-crafted.

The cc changes were done with bash invocations similar to the others
mentioned in the bug.

BUG=401588
==========

to

==========
Use a qualified path for grit-generated headers in components/

The gn and (many!) DEPS changes were lovingly hand-crafted.

The cc changes were done with bash invocations similar to the others
mentioned in the bug.

BUG=401588

Review-Url: https://codereview.chromium.org/2712513004
Cr-Commit-Position: refs/heads/master@{#452591}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe8fa0acd8a31887338bbb2b408c...
==========

[commit-bot: I haz the power, 2017-02-23 19:47:21]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fe8fa0acd8a31887338bbb2b408c...

[Lei Zhang, 2017-02-23 19:58:19]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-02-23 19:58:21]

Thanks for continuing to convert these. I didn't actually look through all the
DEPS files, but it would be nice to sort them all.

https://codereview.chromium.org/2712513004/diff/80001/components/bookmarks/DEPS
File components/bookmarks/DEPS (right):

https://codereview.chromium.org/2712513004/diff/80001/components/bookmarks/DE...
components/bookmarks/DEPS:8: "+components/strings/grit/components_strings.h",
sort?

https://codereview.chromium.org/2712513004/diff/80001/components/crash/core/b...
File components/crash/core/browser/DEPS (right):

https://codereview.chromium.org/2712513004/diff/80001/components/crash/core/b...
components/crash/core/browser/DEPS:3:
"+components/strings/grit/components_chromium_strings.h",
more sorting

https://codereview.chromium.org/2712513004/diff/80001/components/error_page/r...
File components/error_page/renderer/DEPS (right):

https://codereview.chromium.org/2712513004/diff/80001/components/error_page/r...
components/error_page/renderer/DEPS:4:
"+components/strings/grit/components_strings.h",
sort

[Nico, 2017-02-23 20:37:56]

https://codereview.chromium.org/2710973008/

On Thu, Feb 23, 2017 at 2:58 PM, <thestig@chromium.org> wrote:

> Thanks for continuing to convert these. I didn't actually look through all
> the
> DEPS files, but it would be nice to sort them all.
>
>
> https://codereview.chromium.org/2712513004/diff/80001/
> components/bookmarks/DEPS
> File components/bookmarks/DEPS (right):
>
> https://codereview.chromium.org/2712513004/diff/80001/
> components/bookmarks/DEPS#newcode8
> components/bookmarks/DEPS:8:
> "+components/strings/grit/components_strings.h",
> sort?
>
> https://codereview.chromium.org/2712513004/diff/80001/
> components/crash/core/browser/DEPS
> File components/crash/core/browser/DEPS (right):
>
> https://codereview.chromium.org/2712513004/diff/80001/
> components/crash/core/browser/DEPS#newcode3
> components/crash/core/browser/DEPS:3:
> "+components/strings/grit/components_chromium_strings.h",
> more sorting
>
> https://codereview.chromium.org/2712513004/diff/80001/
> components/error_page/renderer/DEPS
> File components/error_page/renderer/DEPS (right):
>
> https://codereview.chromium.org/2712513004/diff/80001/
> components/error_page/renderer/DEPS#newcode4
> components/error_page/renderer/DEPS:4:
> "+components/strings/grit/components_strings.h",
> sort
>
> https://codereview.chromium.org/2712513004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.