Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Issue 2719963002: WPT importer: Fix addition of --cc arguments for test owners. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
tkent, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WPT importer: Fix addition of --cc arguments for test owners. This is a follow-up fix for a mistake in https://crrev.com/2716083002. Example of the error caused by that mistake: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7977/steps/update%20wpt/logs/stdio BUG=684026 Review-Url: https://codereview.chromium.org/2719963002 Cr-Commit-Position: refs/heads/master@{#453321} Committed: https://chromium.googlesource.com/chromium/src/+/25efc8063d6c3af7ae0c9de24051325a77bfe90b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
qyearsley
3 years, 9 months ago (2017-02-27 16:13:49 UTC) #2
qyearsley
3 years, 9 months ago (2017-02-27 18:53:34 UTC) #4
jeffcarp
lgtm
3 years, 9 months ago (2017-02-27 18:59:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719963002/1
3 years, 9 months ago (2017-02-27 19:00:53 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 20:38:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25efc8063d6c3af7ae0c9de24051...

Powered by Google App Engine
This is Rietveld 408576698