Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Issue 2719963002: WPT importer: Fix addition of --cc arguments for test owners. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
index d6fbcd8a252d5a04b45a310ddfd0ee0c39c67963..4c7ab7b4d3686425d54a9104ab36be0b089f2617 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
@@ -183,3 +183,12 @@ class TestImporterTest(LoggingTestCase):
'# external/wpt/foo [ Pass ]\n')
importer = TestImporter(host)
self.assertEqual(importer.get_directory_owners(), {})
+
+ def test_cc_part(self):
+ directory_owners = {
+ ('someone@chromium.org',): ['external/wpt/foo', 'external/wpt/bar'],
+ ('x@chromium.org', 'y@chromium.org'): ['external/wpt/baz'],
+ }
+ self.assertEqual(
+ TestImporter._cc_part(directory_owners),
+ ['--cc=someone@chromium.org', '--cc=x@chromium.org', '--cc=y@chromium.org'])
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698