Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Issue 2719963002: WPT importer: Fix addition of --cc arguments for test owners. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
index 4bb5a936abe567eb24f27512b992e0af0f0131ed..9d91ef4609ca97c9015facfe4b13b475f4cc91a0 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
@@ -374,7 +374,14 @@ class TestImporter(object):
'--gerrit',
'-m',
description,
- ] + ['--cc=' + email_address for email_address in directory_owners])
+ ] + self._cc_part(directory_owners))
+
+ @staticmethod
+ def _cc_part(directory_owners):
+ cc_part = []
+ for owner_tuple in sorted(directory_owners):
+ cc_part.extend('--cc=' + owner for owner in owner_tuple)
+ return cc_part
def get_directory_owners(self):
"""Returns a mapping of email addresses to owners of changed tests."""
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698