tools/chrome_proxy/live_tests/chrome_proxy_measurements.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/live_tests/chrome_proxy_measurements.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_proxy/live_tests/chrome_proxy_measurements.py

diff --git a/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py

index a3174040a537cc334ba33b8681d1abfcfdc881db..126eb89bdb7b013f15fb465b7f62792493711e1a 100644

--- a/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py

+++ b/tools/chrome_proxy/live_tests/chrome_proxy_measurements.py

@@ -22,7 +22,7 @@ class ChromeProxyLatencyBase(legacy_page_test.LegacyPageTest):

def ValidateAndMeasurePage(self, page, tab, results):

# Wait for the load event.

- tab.WaitForJavaScriptCondition2(

+ tab.WaitForJavaScriptCondition(

'performance.timing.loadEventStart', timeout=300)

self._metrics.Stop(page, tab)

self._metrics.AddResultsForLatency(tab, results)