Issue 27197013: Tweak Math.log on ia32/x64

Issue 27197013: Tweak Math.log on ia32/x64 (Closed)

Created:
7 years, 2 months ago by Weiliang

Modified:
7 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Tweak Math.log on ia32/x64 ia32 and x64 more consistent now 1. use non-transcendental cache version of log for x64 2. use negative infinity constant instead of pushing to stack and loading to XMM register 3. remove movdbl, use movsd directly. movdbl seems confusing BUG= R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17268

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -136 lines)			Patch
M	src/ia32/assembler-ia32.h	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View		4 chunks	+3 lines, -12 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		18 chunks	+23 lines, -23 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		10 chunks	+19 lines, -19 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		19 chunks	+26 lines, -27 lines	0 comments	Download
M	src/ia32/lithium-gap-resolver-ia32.cc	View		5 chunks	+10 lines, -10 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		11 chunks	+12 lines, -12 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+29 lines, -4 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/cctest/test-assembler-ia32.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://codereview.chromium.org/27197013/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/27197013/diff/1/src/x64/lithium-codegen-x64.cc#newcode3686 src/x64/lithium-codegen-x64.cc:3686: Operand nan_operand = __ ExternalOperand(nan); nit: ...

7 years, 2 months ago (2013-10-17 12:49:29 UTC) #2

Weiliang

Done https://codereview.chromium.org/27197013/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/27197013/diff/1/src/x64/lithium-codegen-x64.cc#newcode3686 src/x64/lithium-codegen-x64.cc:3686: Operand nan_operand = __ ExternalOperand(nan); On 2013/10/17 12:49:29, ...

7 years, 2 months ago (2013-10-17 13:19:36 UTC) #3

Jakob Kummerow

7 years, 2 months ago (2013-10-18 10:54:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r17268 (presubmit successful).

Expand Messages | Collapse Messages