Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 27197013: Tweak Math.log on ia32/x64 (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: addressed comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/cctest/test-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1209 1209
1210 1210
1211 LInstruction* LChunkBuilder::DoMathAbs(HUnaryMathOperation* instr) { 1211 LInstruction* LChunkBuilder::DoMathAbs(HUnaryMathOperation* instr) {
1212 LOperand* input = UseRegisterAtStart(instr->value()); 1212 LOperand* input = UseRegisterAtStart(instr->value());
1213 LMathAbs* result = new(zone()) LMathAbs(input); 1213 LMathAbs* result = new(zone()) LMathAbs(input);
1214 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 1214 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
1215 } 1215 }
1216 1216
1217 1217
1218 LInstruction* LChunkBuilder::DoMathLog(HUnaryMathOperation* instr) { 1218 LInstruction* LChunkBuilder::DoMathLog(HUnaryMathOperation* instr) {
1219 LOperand* input = UseFixedDouble(instr->value(), xmm1); 1219 ASSERT(instr->representation().IsDouble());
1220 ASSERT(instr->value()->representation().IsDouble());
1221 LOperand* input = UseRegisterAtStart(instr->value());
1220 LMathLog* result = new(zone()) LMathLog(input); 1222 LMathLog* result = new(zone()) LMathLog(input);
1221 return MarkAsCall(DefineFixedDouble(result, xmm1), instr); 1223 return DefineSameAsFirst(result);
1222 } 1224 }
1223 1225
1224 1226
1225 LInstruction* LChunkBuilder::DoMathSin(HUnaryMathOperation* instr) { 1227 LInstruction* LChunkBuilder::DoMathSin(HUnaryMathOperation* instr) {
1226 LOperand* input = UseFixedDouble(instr->value(), xmm1); 1228 LOperand* input = UseFixedDouble(instr->value(), xmm1);
1227 LMathSin* result = new(zone()) LMathSin(input); 1229 LMathSin* result = new(zone()) LMathSin(input);
1228 return MarkAsCall(DefineFixedDouble(result, xmm1), instr); 1230 return MarkAsCall(DefineFixedDouble(result, xmm1), instr);
1229 } 1231 }
1230 1232
1231 1233
(...skipping 1305 matching lines...) Expand 10 before | Expand all | Expand 10 after
2537 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2539 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2538 LOperand* object = UseRegister(instr->object()); 2540 LOperand* object = UseRegister(instr->object());
2539 LOperand* index = UseTempRegister(instr->index()); 2541 LOperand* index = UseTempRegister(instr->index());
2540 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2542 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2541 } 2543 }
2542 2544
2543 2545
2544 } } // namespace v8::internal 2546 } } // namespace v8::internal
2545 2547
2546 #endif // V8_TARGET_ARCH_X64 2548 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/cctest/test-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698