src/x64/lithium-x64.cc - Issue 27197013: Tweak Math.log on ia32/x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 27197013: Tweak Math.log on ia32/x64 (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: addressed comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index 9fb8307983d2d4e6b894ac4873f751228b1dc8ef..6e35237680b24a1df9903588b26c0f1c2a1d0b70 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -1216,9 +1216,11 @@ LInstruction* LChunkBuilder::DoMathAbs(HUnaryMathOperation* instr) {

LInstruction* LChunkBuilder::DoMathLog(HUnaryMathOperation* instr) {

- LOperand* input = UseFixedDouble(instr->value(), xmm1);

+ ASSERT(instr->representation().IsDouble());

+ ASSERT(instr->value()->representation().IsDouble());

+ LOperand* input = UseRegisterAtStart(instr->value());

LMathLog* result = new(zone()) LMathLog(input);

- return MarkAsCall(DefineFixedDouble(result, xmm1), instr);

+ return DefineSameAsFirst(result);

}

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/cctest/test-assembler-ia32.cc » ('j') | no next file with comments »