[LayoutNG] Move NGConstraintSpaceBuilder off Oilpan and DISALLOW_NEW.

[LayoutNG] Move NGConstraintSpaceBuilder off Oilpan and DISALLOW_NEW.

This makes NGConstraintSpaceBuilder and NGFragmentBuilder part of the algorithm
object (not wrapped by a std::unique_ptr anymore).

BUG=635619
Review-Url: https://codereview.chromium.org/2719373002
Cr-Commit-Position: refs/heads/master@{#454099}
Committed: https://chromium.googlesource.com/chromium/src/+/57ec489c4299b535c2c10f4eae838fddf508c442

[ikilpatrick, 2017-02-28 18:28:04]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org, glebl@chromium.org

[ikilpatrick, 2017-02-28 18:28:05]

https://codereview.chromium.org/2719373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2719373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:315:
space_builder_(
We could also do:

class NGConstraintSpaceBuilder {
  DISALLOW_NEW();
};

And just have this as part of the class, thoughts?
(could do the same for NGFragmentBuilder).

[cbiesinger, 2017-02-28 22:09:16]

https://codereview.chromium.org/2719373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2719373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:315:
space_builder_(
On 2017/02/28 18:28:05, ikilpatrick wrote:
> We could also do:
> 
> class NGConstraintSpaceBuilder {
>   DISALLOW_NEW();
> };
> 
> And just have this as part of the class, thoughts?
> (could do the same for NGFragmentBuilder).

Hm... I guess we never reset it / we never need to re-initialize it with a new
constraint space, so that does seem better.

[ikilpatrick, 2017-02-28 22:59:21]

Description was changed from

==========
[LayoutNG] Move NGConstraintSpaceBuilder off Oilpan.

BUG=635619
==========

to

==========
[LayoutNG] Move NGConstraintSpaceBuilder off Oilpan and DISALLOW_NEW.

This makes NGConstraintSpaceBuilder and NGFragmentBuilder part of the algorithm
object (not wrapped by a std::unique_ptr anymore).

BUG=635619
==========

[ikilpatrick, 2017-02-28 22:59:27]

https://codereview.chromium.org/2719373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2719373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:315:
space_builder_(
On 2017/02/28 22:09:16, cbiesinger wrote:
> On 2017/02/28 18:28:05, ikilpatrick wrote:
> > We could also do:
> > 
> > class NGConstraintSpaceBuilder {
> >   DISALLOW_NEW();
> > };
> > 
> > And just have this as part of the class, thoughts?
> > (could do the same for NGFragmentBuilder).
> 
> Hm... I guess we never reset it / we never need to re-initialize it with a new
> constraint space, so that does seem better.

I changed NGFragmentBuilder as well, and updated the patch comment, PTAL :)

[ikilpatrick, 2017-02-28 23:54:53]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:55:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:24:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-03-01 17:30:12]

lgtm

[Gleb Lanbin, 2017-03-01 17:30:13]

lgtm

[cbiesinger, 2017-03-01 17:34:47]

lgtm

[ikilpatrick, 2017-03-01 20:38:27]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2017-03-01 20:38:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, glebl@chromium.org
Link to the patchset: https://codereview.chromium.org/2719373002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-01 20:39:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 23:47:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488400707578850,
"parent_rev": "515321aa08c29e910a720af8b3752ab52826df22", "commit_rev":
"57ec489c4299b535c2c10f4eae838fddf508c442"}

[commit-bot: I haz the power, 2017-03-01 23:48:05]

Description was changed from

==========
[LayoutNG] Move NGConstraintSpaceBuilder off Oilpan and DISALLOW_NEW.

This makes NGConstraintSpaceBuilder and NGFragmentBuilder part of the algorithm
object (not wrapped by a std::unique_ptr anymore).

BUG=635619
==========

to

==========
[LayoutNG] Move NGConstraintSpaceBuilder off Oilpan and DISALLOW_NEW.

This makes NGConstraintSpaceBuilder and NGFragmentBuilder part of the algorithm
object (not wrapped by a std::unique_ptr anymore).

BUG=635619

Review-Url: https://codereview.chromium.org/2719373002
Cr-Commit-Position: refs/heads/master@{#454099}
Committed:
https://chromium.googlesource.com/chromium/src/+/57ec489c4299b535c2c10f4eae83...
==========

[commit-bot: I haz the power, 2017-03-01 23:48:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/57ec489c4299b535c2c10f4eae83...