third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h - Issue 2719373002: [LayoutNG] Move NGConstraintSpaceBuilder off Oilpan and DISALLOW_NEW.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2719373002: [LayoutNG] Move NGConstraintSpaceBuilder off Oilpan and DISALLOW_NEW. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

index ddf0703a6bf0f3c5616fcbb4245441b7acda850e..c4e5bf1a6b98eecbcd73a86b94336fa997fd0e55 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

@@ -7,12 +7,14 @@

#include "core/layout/ng/ng_constraint_space.h"

#include "core/layout/ng/ng_units.h"

+#include "wtf/Allocator.h"

#include "wtf/Optional.h"

namespace blink {

-class CORE_EXPORT NGConstraintSpaceBuilder final

- : public GarbageCollectedFinalized<NGConstraintSpaceBuilder> {

+class CORE_EXPORT NGConstraintSpaceBuilder final {

+ DISALLOW_NEW();

public:

NGConstraintSpaceBuilder(const NGConstraintSpace* parent_space);

@@ -63,8 +65,6 @@ class CORE_EXPORT NGConstraintSpaceBuilder final

// NGWritingMode specifies the writing mode of the generated space.

NGConstraintSpace* ToConstraintSpace(NGWritingMode);

- DEFINE_INLINE_TRACE() {}

private:

// Relative to parent_writing_mode_.

NGLogicalSize available_size_;