Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 27192003: Start cleaning up 64bit Win warnings (Closed)

Created:
7 years, 2 months ago by robertphillips
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Start cleaning up 64bit Win warnings In service of Skia issue 1695 (64-bit Mac and Windows bots reporting warnings - https://code.google.com/p/skia/issues/detail?id=1695)

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : fixed SkAutoSTArray #

Patch Set 4 : cleaned up #

Total comments: 2

Patch Set 5 : revertedGrBytesPerPixel to returning a size_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -53 lines) Patch
M include/core/SkTemplates.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M include/core/SkWriter32.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M include/utils/SkMeshUtils.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkOrderedWriteBuffer.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRTree.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRTree.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrIndexBuffer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrMemoryPool.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrFontScaler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_win_dw.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/utils/win/SkWGL_win.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skdiff_utils.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/skpdiff/skpdiff_util.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
7 years, 2 months ago (2013-10-14 14:59:19 UTC) #1
bsalomon
https://codereview.chromium.org/27192003/diff/3001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/27192003/diff/3001/src/gpu/GrDrawState.h#newcode1017 src/gpu/GrDrawState.h:1017: int coverageStageCnt = int(fStages.count()) - fColorStageCnt; I think we ...
7 years, 2 months ago (2013-10-14 15:17:02 UTC) #2
robertphillips
I recognize a mandate to cause trouble when I see one. PTAL. https://codereview.chromium.org/27192003/diff/3001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h ...
7 years, 2 months ago (2013-10-14 17:39:26 UTC) #3
bsalomon
https://codereview.chromium.org/27192003/diff/10001/include/gpu/GrTypes.h File include/gpu/GrTypes.h (right): https://codereview.chromium.org/27192003/diff/10001/include/gpu/GrTypes.h#newcode318 include/gpu/GrTypes.h:318: static inline int GrBytesPerPixel(GrPixelConfig config) { Hmm.. seems like ...
7 years, 2 months ago (2013-10-14 19:27:36 UTC) #4
robertphillips
https://codereview.chromium.org/27192003/diff/10001/include/gpu/GrTypes.h File include/gpu/GrTypes.h (right): https://codereview.chromium.org/27192003/diff/10001/include/gpu/GrTypes.h#newcode318 include/gpu/GrTypes.h:318: static inline int GrBytesPerPixel(GrPixelConfig config) { On 2013/10/14 19:27:37, ...
7 years, 2 months ago (2013-10-14 19:51:11 UTC) #5
bsalomon
lgtm
7 years, 2 months ago (2013-10-14 19:53:16 UTC) #6
robertphillips
7 years, 2 months ago (2013-10-14 21:53:51 UTC) #7
Message was sent while issue was closed.
committed as r11764

Powered by Google App Engine
This is Rietveld 408576698