chromeos: makes more tests run in both mash and ash

chromeos: makes more tests run in both mash and ash

BUG=693114, 581462, 647438, 695628, 695629, 695632, 695640, 695686, 695751, 695758, 695887, 696006, 696028
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}
Committed: https://chromium.googlesource.com/chromium/src/+/56ce72b787bcd211e206ec4d49bb06f07590ca3f

[sky, 2017-02-24 21:12:20]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:13:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-02-24 21:25:35]

lgtm with nits

https://codereview.chromium.org/2718763003/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2718763003/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager_unittest.cc:959: // Fails because of
AppListPresenter.
nit: file a bug, cite it here and on line 991, 1059, and 1099. We'll need to use
TestAppListPresenter or maybe something like ExampleAppListPresenter.

https://codereview.chromium.org/2718763003/diff/1/ash/shell_unittest.cc
File ash/shell_unittest.cc (right):

https://codereview.chromium.org/2718763003/diff/1/ash/shell_unittest.cc#newco...
ash/shell_unittest.cc:512: // valid as content is in another process in mash.
nit: "a separate process from"? (or more to the point, content windows aren't
constructed/embedded in the same manner, even if ash and chrome services were
run in the same process for mash)... Maybe just mention that this test should be
deleted when mash is the only supported configuration.

[sky, 2017-02-24 21:39:52]

Description was changed from

==========
chromeos: makes more tests run in both mash and ash

BUG=693114,581462,647438,695628,695629,695632,695640,695686,695751,695758,695887,696006
TEST=test only changes
R=msw@chromium.org
==========

to

==========
chromeos: makes more tests run in both mash and ash

BUG=693114,581462,647438,695628,695629,695632,695640,695686,695751,695758,695887,696006,696028
TEST=test only changes
R=msw@chromium.org
==========

[sky, 2017-02-24 21:43:47]

https://codereview.chromium.org/2718763003/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2718763003/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager_unittest.cc:959: // Fails because of
AppListPresenter.
On 2017/02/24 21:25:34, msw wrote:
> nit: file a bug, cite it here and on line 991, 1059, and 1099. We'll need to
use
> TestAppListPresenter or maybe something like ExampleAppListPresenter.

Done.

https://codereview.chromium.org/2718763003/diff/1/ash/shell_unittest.cc
File ash/shell_unittest.cc (right):

https://codereview.chromium.org/2718763003/diff/1/ash/shell_unittest.cc#newco...
ash/shell_unittest.cc:512: // valid as content is in another process in mash.
On 2017/02/24 21:25:35, msw wrote:
> nit: "a separate process from"? (or more to the point, content windows aren't
> constructed/embedded in the same manner, even if ash and chrome services were
> run in the same process for mash)... Maybe just mention that this test should
be
> deleted when mash is the only supported configuration.

Done.

[sky, 2017-02-24 21:43:57]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:44:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:26:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-02-27 16:48:25]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 16:48:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-02-27 17:41:12]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 17:41:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 18:57:31]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-27 18:59:07]

The CQ bit was checked by sky@chromium.org

[sky, 2017-02-27 18:59:07]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2718763003/#ps60001
(title: "disable more ShelfViewTests")

[commit-bot: I haz the power, 2017-02-27 19:00:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:07:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488221947509940,
"parent_rev": "e72a513a6c84075089ecda0570ce658d0b45f6dd", "commit_rev":
"56ce72b787bcd211e206ec4d49bb06f07590ca3f"}

[commit-bot: I haz the power, 2017-02-27 19:07:55]

Description was changed from

==========
chromeos: makes more tests run in both mash and ash

BUG=693114,581462,647438,695628,695629,695632,695640,695686,695751,695758,695887,696006,696028
TEST=test only changes
R=msw@chromium.org
==========

to

==========
chromeos: makes more tests run in both mash and ash

BUG=693114,581462,647438,695628,695629,695632,695640,695686,695751,695758,695887,696006,696028
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}
Committed:
https://chromium.googlesource.com/chromium/src/+/56ce72b787bcd211e206ec4d49bb...
==========

[commit-bot: I haz the power, 2017-02-27 19:07:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/56ce72b787bcd211e206ec4d49bb...