Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 2718763003: chromeos: makes more tests run in both mash and ash (Closed)
Patch Set: disable more ShelfViewTests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_layout_manager_unittest.cc ('k') | ash/shell_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_view_unittest.cc
diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc
index d3a1b3d3a4c6ef74c2a2af6d0f604e8557a37832..01d7681d012c8ebcb058f28205bbaa2f9369b901 100644
--- a/ash/shelf/shelf_view_unittest.cc
+++ b/ash/shelf/shelf_view_unittest.cc
@@ -197,6 +197,10 @@ TEST_F(WmShelfObserverIconTest, AddRemove) {
// Make sure creating/deleting an window on one displays notifies a
// shelf on external display as well as one on primary.
TEST_F(WmShelfObserverIconTest, AddRemoveWithMultipleDisplays) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
UpdateDisplay("400x400,400x400");
WmWindow* second_root = WmShell::Get()->GetAllRootWindows()[1];
WmShelf* second_shelf = second_root->GetRootWindowController()->GetShelf();
@@ -857,6 +861,10 @@ TEST_F(ShelfViewTest, AddAppShortcutWithBrowserButtonUntilOverflow) {
}
TEST_F(ShelfViewTest, AddPanelHidesPlatformAppButton) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
// All buttons should be visible.
ASSERT_EQ(test_api_->GetButtonCount(), test_api_->GetLastVisibleIndex() + 1);
@@ -1569,6 +1577,10 @@ TEST_F(ShelfViewTest, ResizeDuringOverflowAddAnimation) {
// Checks the overflow bubble size when an item is ripped off and re-inserted.
TEST_F(ShelfViewTest, OverflowBubbleSize) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
shelf_delegate_->set_is_app_pinned(true);
AddButtonsUntilOverflow();
// Add one more button to prevent the overflow bubble to disappear upon
@@ -1623,6 +1635,10 @@ TEST_F(ShelfViewTest, OverflowBubbleSize) {
// Check the drag insertion bounds of scrolled overflow bubble.
TEST_F(ShelfViewTest, CheckDragInsertBoundsOfScrolledOverflowBubble) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
UpdateDisplay("400x300");
EXPECT_EQ(2, model_->item_count());
@@ -1774,6 +1790,10 @@ TEST_F(ShelfViewTest, CheckRipOffFromLeftShelfAlignmentWithMultiMonitor) {
// Checks various drag and drop operations from OverflowBubble to Shelf.
TEST_F(ShelfViewTest, CheckDragAndDropFromOverflowBubbleToShelf) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
AddButtonsUntilOverflow();
// Add one more button to prevent the overflow bubble to disappear upon
// dragging an item out on windows (flakiness, see crbug.com/425097).
@@ -1803,6 +1823,10 @@ TEST_F(ShelfViewTest, CheckOverflowStatusPinOpenedAppToShelf) {
// item is selected.
TEST_F(ShelfViewTest,
Launcher_ButtonPressedUserActionsRecordedWhenItemSelected) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
base::UserActionTester user_action_tester;
ShelfID browser_shelf_id = model_->items()[browser_index_].id;
@@ -1818,6 +1842,10 @@ TEST_F(ShelfViewTest,
// Verifies that Launcher_*Task UMA user actions are recorded when an item is
// selected.
TEST_F(ShelfViewTest, Launcher_TaskUserActionsRecordedWhenItemSelected) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
base::UserActionTester user_action_tester;
ShelfID browser_shelf_id = model_->items()[browser_index_].id;
@@ -2040,6 +2068,10 @@ class ShelfViewInkDropTest : public ShelfViewTest {
// Tests that changing visibility of the app list transitions app list button's
// ink drop states correctly.
TEST_F(ShelfViewInkDropTest, AppListButtonWhenVisibilityChanges) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();
@@ -2093,6 +2125,10 @@ TEST_F(ShelfViewInkDropTest, AppListButtonMouseEventsWhenHidden) {
// which dismisses the app list, transitions ink drop states correctly. Also,
// tests that mouse drag and mouse release does not affect the ink drop state.
TEST_F(ShelfViewInkDropTest, AppListButtonMouseEventsWhenVisible) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();
@@ -2156,6 +2192,10 @@ TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapWhenHidden) {
// Tests that when the app list is visible, tapping on the app list button
// transitions ink drop states correctly.
TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapWhenVisible) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();
@@ -2222,6 +2262,10 @@ TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapDragWhenHidden) {
// Tests that when the app list is visible, tapping down on the app list button
// and dragging the touch point transitions ink drop states correctly.
TEST_F(ShelfViewInkDropTest, AppListButtonGestureTapDragWhenVisible) {
+ // TODO: investigate failure in mash, http://crbug.com/695751.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
InitAppListButtonInkDrop();
ShowAppList();
« no previous file with comments | « ash/shelf/shelf_layout_manager_unittest.cc ('k') | ash/shell_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698