Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: ash/sticky_keys/sticky_keys_overlay_unittest.cc

Issue 2718763003: chromeos: makes more tests run in both mash and ash (Closed)
Patch Set: disable more ShelfViewTests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/sticky_keys/sticky_keys_overlay.h" 5 #include "ash/sticky_keys/sticky_keys_overlay.h"
6 6
7 #include "ash/common/wm_shell.h"
7 #include "ash/display/window_tree_host_manager.h" 8 #include "ash/display/window_tree_host_manager.h"
8 #include "ash/shell.h" 9 #include "ash/shell.h"
9 #include "ash/sticky_keys/sticky_keys_controller.h" 10 #include "ash/sticky_keys/sticky_keys_controller.h"
10 #include "ash/test/ash_test_base.h" 11 #include "ash/test/ash_test_base.h"
11 #include "ui/display/display_layout.h" 12 #include "ui/display/display_layout.h"
12 #include "ui/display/manager/display_manager.h" 13 #include "ui/display/manager/display_manager.h"
13 #include "ui/display/test/display_manager_test_api.h" 14 #include "ui/display/test/display_manager_test_api.h"
14 #include "ui/events/event.h" 15 #include "ui/events/event.h"
15 #include "ui/views/widget/widget.h" 16 #include "ui/views/widget/widget.h"
16 17
(...skipping 21 matching lines...) Expand all
38 overlay.GetModifierKeyState(ui::EF_ALT_DOWN)); 39 overlay.GetModifierKeyState(ui::EF_ALT_DOWN));
39 EXPECT_EQ(STICKY_KEY_STATE_ENABLED, 40 EXPECT_EQ(STICKY_KEY_STATE_ENABLED,
40 overlay.GetModifierKeyState(ui::EF_CONTROL_DOWN)); 41 overlay.GetModifierKeyState(ui::EF_CONTROL_DOWN));
41 EXPECT_EQ(STICKY_KEY_STATE_LOCKED, 42 EXPECT_EQ(STICKY_KEY_STATE_LOCKED,
42 overlay.GetModifierKeyState(ui::EF_COMMAND_DOWN)); 43 overlay.GetModifierKeyState(ui::EF_COMMAND_DOWN));
43 } 44 }
44 45
45 // This test addresses the crash report at crbug.com/435600, speculated to be 46 // This test addresses the crash report at crbug.com/435600, speculated to be
46 // caused by using sticky keys with multiple displays. 47 // caused by using sticky keys with multiple displays.
47 TEST_F(StickyKeysOverlayTest, OverlayNotDestroyedAfterDisplayRemoved) { 48 TEST_F(StickyKeysOverlayTest, OverlayNotDestroyedAfterDisplayRemoved) {
49 // TODO: investigate failure in mash, http://crbug.com/696006.
50 if (WmShell::Get()->IsRunningInMash())
51 return;
52
48 // Add a secondary display to the left of the primary one. 53 // Add a secondary display to the left of the primary one.
49 UpdateDisplay("1280x1024,1980x1080"); 54 UpdateDisplay("1280x1024,1980x1080");
50 display::DisplayIdList display_ids = 55 display::DisplayIdList display_ids =
51 display_manager()->GetCurrentDisplayIdList(); 56 display_manager()->GetCurrentDisplayIdList();
52 int64_t primary_display_id = display_ids[0]; 57 int64_t primary_display_id = display_ids[0];
53 int64_t secondary_display_id = display_ids[1]; 58 int64_t secondary_display_id = display_ids[1];
54 display_manager()->SetLayoutForCurrentDisplays( 59 display_manager()->SetLayoutForCurrentDisplays(
55 display::test::CreateDisplayLayout(display_manager(), 60 display::test::CreateDisplayLayout(display_manager(),
56 display::DisplayPlacement::LEFT, 0)); 61 display::DisplayPlacement::LEFT, 0));
57 62
(...skipping 18 matching lines...) Expand all
76 overlay.GetModifierKeyState(ui::EF_SHIFT_DOWN)); 81 overlay.GetModifierKeyState(ui::EF_SHIFT_DOWN));
77 overlay.SetModifierKeyState(ui::EF_SHIFT_DOWN, STICKY_KEY_STATE_DISABLED); 82 overlay.SetModifierKeyState(ui::EF_SHIFT_DOWN, STICKY_KEY_STATE_DISABLED);
78 EXPECT_EQ(STICKY_KEY_STATE_DISABLED, 83 EXPECT_EQ(STICKY_KEY_STATE_DISABLED,
79 overlay.GetModifierKeyState(ui::EF_SHIFT_DOWN)); 84 overlay.GetModifierKeyState(ui::EF_SHIFT_DOWN));
80 } 85 }
81 86
82 // Additional sticky key overlay tests that depend on chromeos::EventRewriter 87 // Additional sticky key overlay tests that depend on chromeos::EventRewriter
83 // are now in chrome/browser/chromeos/events/event_rewriter_unittest.cc . 88 // are now in chrome/browser/chromeos/events/event_rewriter_unittest.cc .
84 89
85 } // namespace ash 90 } // namespace ash
OLDNEW
« no previous file with comments | « ash/shell_unittest.cc ('k') | ash/system/chromeos/power/tablet_power_button_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698