Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2718733003: Removed -[CRWWebDelegate webDidUpdateHistoryStateWithPageURL]. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed -[CRWWebDelegate webDidUpdateHistoryStateWithPageURL]. Replaced with webState:didFinishNavigation:, which is also added in this CL. BUG=692331 Review-Url: https://codereview.chromium.org/2718733003 Cr-Commit-Position: refs/heads/master@{#453732} Committed: https://chromium.googlesource.com/chromium/src/+/bd25aca5753c52eb1c0e348c0146589df14802bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -21 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 2 chunks +9 lines, -6 lines 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.h View 2 chunks +12 lines, -1 line 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.mm View 3 chunks +14 lines, -0 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/public/web_state/web_state_observer_bridge.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +4 lines, -11 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge_unittest.mm View 2 chunks +16 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-02-24 21:04:20 UTC) #6
Eugene But (OOO till 7-30)
Kurt?
3 years, 9 months ago (2017-02-28 19:52:32 UTC) #7
kkhorimoto
lgtm
3 years, 9 months ago (2017-02-28 20:20:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718733003/1
3 years, 9 months ago (2017-02-28 21:40:42 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:15:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd25aca5753c52eb1c0e348c0146...

Powered by Google App Engine
This is Rietveld 408576698