Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: ios/web/public/test/fakes/crw_test_web_state_observer.mm

Issue 2718733003: Removed -[CRWWebDelegate webDidUpdateHistoryStateWithPageURL]. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/test/fakes/crw_test_web_state_observer.mm
diff --git a/ios/web/public/test/fakes/crw_test_web_state_observer.mm b/ios/web/public/test/fakes/crw_test_web_state_observer.mm
index 755753f1660e00ca3a68a520de3069f565affb6f..b5b0190f9b884e1bb25cc4b445c14421cf241e0f 100644
--- a/ios/web/public/test/fakes/crw_test_web_state_observer.mm
+++ b/ios/web/public/test/fakes/crw_test_web_state_observer.mm
@@ -18,6 +18,8 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() =
// Arguments passed to |webState:didStartProvisionalNavigationForURL:|.
std::unique_ptr<web::TestStartProvisionalNavigationInfo>
_startProvisionalNavigationInfo;
+ // Arguments passed to |webState:didFinishNavigationForURL:|.
+ std::unique_ptr<web::TestDidFinishNavigationInfo> _didFinishNavigationInfo;
// Arguments passed to |webState:didCommitNavigationWithDetails:|.
std::unique_ptr<web::TestCommitNavigationInfo> _commitNavigationInfo;
// Arguments passed to |webState:didLoadPageWithSuccess:|.
@@ -54,6 +56,10 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() =
return _startProvisionalNavigationInfo.get();
}
+- (web::TestDidFinishNavigationInfo*)didFinishNavigationInfo {
+ return _didFinishNavigationInfo.get();
+}
+
- (web::TestCommitNavigationInfo*)commitNavigationInfo {
return _commitNavigationInfo.get();
}
@@ -124,6 +130,14 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() =
_commitNavigationInfo->load_details = load_details;
}
+- (void)webState:(web::WebState*)webState
+ didFinishNavigation:(web::NavigationContext*)navigation {
+ _didFinishNavigationInfo =
+ base::MakeUnique<web::TestDidFinishNavigationInfo>();
+ _didFinishNavigationInfo->web_state = webState;
+ _didFinishNavigationInfo->context = navigation;
+}
+
- (void)webState:(web::WebState*)webState didLoadPageWithSuccess:(BOOL)success {
_loadPageInfo = base::MakeUnique<web::TestLoadPageInfo>();
_loadPageInfo->web_state = webState;
« no previous file with comments | « ios/web/public/test/fakes/crw_test_web_state_observer.h ('k') | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698