Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2712363005: Extracted WebStateTest from WebStateImpl. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extracted WebStateTest from WebStateImpl. WebStateImplTest will remain a subclass of web::WebTest and will keep testing WebStateImpl API. WebStateTest became a subclass of web::WebTestWithWebState and will be responsible for testing public web::WebState API. Subclassing from web::WebTestWithWebState will allow WebStateTest to use utility methods like LoadHtml, ExecuteJavaScript and WaitForCondition. BUG=None Review-Url: https://codereview.chromium.org/2712363005 Cr-Commit-Position: refs/heads/master@{#453813} Committed: https://chromium.googlesource.com/chromium/src/+/c110fd587e6e7b835f51d1305bdf0d9ac51ac99e

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : One more self review :) #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased again #

Patch Set 6 : Fixed compilation #

Patch Set 7 : Rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -99 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 2 3 4 5 6 11 chunks +14 lines, -99 lines 0 comments Download
A ios/web/web_state/web_state_unittest.mm View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-02-28 22:46:21 UTC) #3
kkhorimoto
lgtm
3 years, 9 months ago (2017-03-01 00:00:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712363005/90001
3 years, 9 months ago (2017-03-01 01:42:20 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/162177) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-01 01:45:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712363005/110001
3 years, 9 months ago (2017-03-01 01:49:50 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:13:15 UTC) #26
Message was sent while issue was closed.
Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/c110fd587e6e7b835f51d1305bdf...

Powered by Google App Engine
This is Rietveld 408576698