Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2717613002: MD Settings: add a bunch of dialog (X) aria-labels (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, tfarina, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add a bunch of dialog (X) aria-labels R=dpapad@chromium.org BUG=693373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2717613002 Cr-Commit-Position: refs/heads/master@{#452744} Committed: https://chromium.googlesource.com/chromium/src/+/067993e006fab2c08cd42cda616e65e682b17305

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M chrome/browser/resources/settings/about_page/channel_switcher_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/android_apps_page/android_apps_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/display_overscan_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/drive_cache_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/add_languages_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/import_data_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/setup_pin_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/users_add_user_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/reset_page/powerwash_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_banner.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/add_site_dialog.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Dan Beam
3 years, 10 months ago (2017-02-24 00:25:10 UTC) #2
dpapad
On 2017/02/24 at 00:25:10, dbeam wrote: > LGTM, but also summarizing offline conversation: I would ...
3 years, 10 months ago (2017-02-24 00:39:06 UTC) #5
Dan Beam
On 2017/02/24 00:39:06, dpapad wrote: > On 2017/02/24 at 00:25:10, dbeam wrote: > > > ...
3 years, 10 months ago (2017-02-24 01:06:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717613002/1
3 years, 10 months ago (2017-02-24 01:07:03 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/settings/site_settings/add_site_dialog.html: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-24 01:53:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717613002/20001
3 years, 10 months ago (2017-02-24 02:59:58 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 03:59:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/067993e006fab2c08cd42cda616e...

Powered by Google App Engine
This is Rietveld 408576698