chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html - Issue 2717613002: MD Settings: add a bunch of dialog (X) aria-labels

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html

Issue 2717613002: MD Settings: add a bunch of dialog (X) aria-labels (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_profile_dialog.html ('k') | chrome/browser/resources/settings/site_settings/add_site_dialog.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">	1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

5 <link rel="import" href="../i18n_setup.html">	5 <link rel="import" href="../i18n_setup.html">

6 <link rel="import" href="search_engines_browser_proxy.html">	6 <link rel="import" href="search_engines_browser_proxy.html">

7	7

8 <dom-module id="settings-search-engine-dialog">	8 <dom-module id="settings-search-engine-dialog">

9 <template>	9 <template>

10 <style include="settings-shared"></style>	10 <style include="settings-shared"></style>

11 <dialog is="cr-dialog" id="dialog">	11 <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}">

12 <div class="title">[[dialogTitle_]]</div>	12 <div class="title">[[dialogTitle_]]</div>

13 <div class="body" on-keypress="onKeypress_">	13 <div class="body" on-keypress="onKeypress_">

14 <paper-input always-float-label id="searchEngine"	14 <paper-input always-float-label id="searchEngine"

15 label="$i18n{searchEnginesSearchEngine}"	15 label="$i18n{searchEnginesSearchEngine}"

16 error-message="$i18n{searchEnginesNotValid}"	16 error-message="$i18n{searchEnginesNotValid}"

17 value="{{searchEngine_}}" on-input="validate_">	17 value="{{searchEngine_}}" on-input="validate_">

18 </paper-input>	18 </paper-input>

19 <paper-input always-float-label id="keyword"	19 <paper-input always-float-label id="keyword"

20 label="$i18n{searchEnginesKeyword}"	20 label="$i18n{searchEnginesKeyword}"

21 error-message="$i18n{searchEnginesNotValid}"	21 error-message="$i18n{searchEnginesNotValid}"

(...skipping 11 matching lines...) Expand all Loading...
33 $i18n{cancel}</paper-button>	33 $i18n{cancel}</paper-button>

34 <paper-button id="actionButton" class="action-button"	34 <paper-button id="actionButton" class="action-button"

35 on-tap="onActionButtonTap_">	35 on-tap="onActionButtonTap_">

36 [[actionButtonText_]]	36 [[actionButtonText_]]

37 </paper-button>	37 </paper-button>

38 </div>	38 </div>

39 </dialog>	39 </dialog>

40 </template>	40 </template>

41 <script src="search_engine_dialog.js"></script>	41 <script src="search_engine_dialog.js"></script>

42 </dom-module>	42 </dom-module>

OLD	NEW